Skip to content

Commit dc4f19e

Browse files
committed
[skip ci] Remove PECL build
This build is not useful for multiple reasons: - Legitimate API changes keep making the build red. Frequently it takes 3rd party extension developers months to fix these issues. - Once we're annoyed enough by the red build we skip it and then don't revert it way after it has been fixed. - True accidental API changes are incredibly rare. I don't believe I've experienced one yet. - This build only runs for master, which is also the branch where accidental changes are least problematic. Closes GH-21980
1 parent a03961b commit dc4f19e

2 files changed

Lines changed: 0 additions & 112 deletions

File tree

.github/matrix.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re
6161
$test_macos = in_array('CI: macOS', $labels, true);
6262
$test_msan = in_array('CI: MSAN', $labels, true);
6363
$test_opcache_variation = in_array('CI: Opcache Variation', $labels, true);
64-
$test_pecl = in_array('CI: PECL', $labels, true);
6564
$test_solaris = in_array('CI: Solaris', $labels, true);
6665
$test_windows = in_array('CI: Windows', $labels, true);
6766

@@ -137,9 +136,6 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re
137136
if ($all_jobs || $test_opcache_variation) {
138137
$jobs['OPCACHE_VARIATION'] = true;
139138
}
140-
if (($all_jobs && $ref === 'master') || $test_pecl) {
141-
$jobs['PECL'] = true;
142-
}
143139
if (version_compare($php_version, '8.6', '>=') && ($all_jobs || $test_solaris)) {
144140
$jobs['SOLARIS'] = true;
145141
}

.github/workflows/test-suite.yml

Lines changed: 0 additions & 108 deletions
Original file line numberDiff line numberDiff line change
@@ -827,114 +827,6 @@ jobs:
827827
uses: ./.github/actions/test-libmysqlclient
828828
- name: Verify generated files are up to date
829829
uses: ./.github/actions/verify-generated-files
830-
PECL:
831-
if: ${{ fromJson(inputs.branch).jobs.PECL }}
832-
runs-on: ubuntu-24.04
833-
steps:
834-
- name: git checkout PHP
835-
uses: actions/checkout@v6
836-
with:
837-
path: php
838-
ref: ${{ fromJson(inputs.branch).ref }}
839-
# Used for ccache action
840-
- name: Move .github
841-
run: mv php/.github .
842-
- name: git checkout apcu
843-
uses: actions/checkout@v6
844-
with:
845-
repository: krakjoe/apcu
846-
path: apcu
847-
- name: git checkout imagick
848-
uses: actions/checkout@v6
849-
with:
850-
repository: Imagick/imagick
851-
path: imagick
852-
- name: git checkout memcached
853-
uses: actions/checkout@v6
854-
with:
855-
repository: php-memcached-dev/php-memcached
856-
path: memcached
857-
- name: git checkout redis
858-
if: ${{ false }}
859-
uses: actions/checkout@v6
860-
with:
861-
repository: phpredis/phpredis
862-
path: redis
863-
- name: git checkout xdebug
864-
uses: actions/checkout@v6
865-
with:
866-
repository: xdebug/xdebug
867-
path: xdebug
868-
- name: git checkout yaml
869-
uses: actions/checkout@v6
870-
with:
871-
repository: php/pecl-file_formats-yaml
872-
path: yaml
873-
- name: apt
874-
run: |
875-
sudo apt-get update
876-
sudo apt-get install -y --no-install-recommends \
877-
ccache \
878-
libmemcached-dev \
879-
imagemagick \
880-
libmagickwand-dev \
881-
bison \
882-
re2c
883-
- name: ccache
884-
uses: ./.github/actions/ccache
885-
with:
886-
name: "${{ github.job }}"
887-
php_directory: php
888-
- name: build PHP
889-
run: |
890-
cd php
891-
./buildconf --force
892-
./configure \
893-
--enable-option-checking=fatal \
894-
--prefix=/opt/php \
895-
--enable-cli \
896-
--disable-all \
897-
--enable-session \
898-
--enable-werror
899-
make -j$(/usr/bin/nproc)
900-
sudo make install
901-
- name: build apcu
902-
run: |
903-
cd apcu
904-
/opt/php/bin/phpize
905-
./configure --prefix=/opt/php --with-php-config=/opt/php/bin/php-config
906-
make -j$(/usr/bin/nproc)
907-
- name: build imagick
908-
run: |
909-
cd imagick
910-
/opt/php/bin/phpize
911-
./configure --prefix=/opt/php --with-php-config=/opt/php/bin/php-config
912-
make -j$(/usr/bin/nproc)
913-
- name: build memcached
914-
run: |
915-
cd memcached
916-
/opt/php/bin/phpize
917-
./configure --prefix=/opt/php --with-php-config=/opt/php/bin/php-config
918-
make -j$(/usr/bin/nproc)
919-
- name: build redis
920-
if: ${{ false }}
921-
run: |
922-
cd redis
923-
/opt/php/bin/phpize
924-
./configure --prefix=/opt/php --with-php-config=/opt/php/bin/php-config
925-
make -j$(/usr/bin/nproc)
926-
- name: build xdebug
927-
run: |
928-
cd xdebug
929-
/opt/php/bin/phpize
930-
./configure --prefix=/opt/php --with-php-config=/opt/php/bin/php-config
931-
make -j$(/usr/bin/nproc)
932-
- name: build yaml
933-
run: |
934-
cd yaml
935-
/opt/php/bin/phpize
936-
./configure --prefix=/opt/php --with-php-config=/opt/php/bin/php-config
937-
make -j$(/usr/bin/nproc)
938830
WINDOWS:
939831
if: ${{ fromJson(inputs.branch).jobs.WINDOWS }}
940832
strategy:

0 commit comments

Comments
 (0)