Skip to content

Commit cf7c6d2

Browse files
theodorejbderickr
authored andcommitted
Remove pixel-perfect screenshot tests
Per feedback from other maintainers, these tests will just be a waste of time as we make numerous necessary design fixes and improvements.
1 parent aff76fd commit cf7c6d2

18 files changed

Lines changed: 6 additions & 204 deletions

.github/workflows/preview-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
types: [ labeled ]
55

66
jobs:
7-
tests_visual:
8-
name: "Visual Tests"
7+
tests_e2e:
8+
name: "E2E Tests"
99
runs-on: "ubuntu-latest"
1010
if: "github.repository_owner == 'php' && contains(github.event.pull_request.labels.*.name, 'Status: Preview Allowed')"
1111

@@ -77,8 +77,8 @@ jobs:
7777
- name: "Install Playwright"
7878
run: "npx playwright install"
7979

80-
- name: "Run visual tests"
81-
run: "make tests_visual"
80+
- name: "Run E2E tests"
81+
run: "make tests_e2e"
8282

8383
- name: Upload playwright report
8484
uses: actions/upload-artifact@v7

.github/workflows/update-screenshots.yaml

Lines changed: 0 additions & 74 deletions
This file was deleted.

Makefile

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,9 @@ tests: vendor ## Runs unit and end-to-end tests with phpunit/phpunit
2626
vendor/bin/phpunit --configuration=tests/phpunit.xml --testsuite=end-to-end;
2727
tests/server stop
2828

29-
tests_visual:
29+
tests_e2e:
3030
tests/server start;
31-
npx playwright test --workers=$(CORES)
32-
tests/server stop
33-
34-
tests_update_snapshots:
35-
tests/server start;
36-
npx playwright test --update-snapshots
31+
npx playwright test
3732
tests/server stop
3833

3934
vendor: composer.json composer.lock

playwright.config.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ export default defineConfig({
3030
timeout: 0,
3131

3232
projects: [
33-
{
34-
name: 'chromium',
35-
use: {...devices['Desktop Chrome']},
36-
testDir: './tests/Visual',
37-
},
3833
{
3934
name: 'End-to-End Chromium',
4035
use: {...devices['Desktop Chrome']},

tests/Visual/SearchModal.css

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/Visual/SearchModal.spec.ts

Lines changed: 0 additions & 35 deletions
This file was deleted.
Binary file not shown.

tests/Visual/SmokeTest.spec.ts

Lines changed: 0 additions & 76 deletions
This file was deleted.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)