From ee29052cfacfdb307bd91c5308e14a3f8ea3ae76 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 29 Mar 2026 22:33:53 +0000 Subject: [PATCH] fix: rename misleading \$isFinal variable to \$isTrait in IsTraitTest Variable was copy-pasted from IsFinalTest without being renamed, causing confusion despite the test itself being correct. https://claude.ai/code/session_01WXeXUHXmMjTwxx3RtBNh9B --- tests/Unit/Expressions/ForClasses/IsTraitTest.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/Unit/Expressions/ForClasses/IsTraitTest.php b/tests/Unit/Expressions/ForClasses/IsTraitTest.php index cdd8281b..49cb9c60 100644 --- a/tests/Unit/Expressions/ForClasses/IsTraitTest.php +++ b/tests/Unit/Expressions/ForClasses/IsTraitTest.php @@ -13,7 +13,7 @@ class IsTraitTest extends TestCase { public function test_it_should_return_violation_error(): void { - $isFinal = new IsTrait(); + $isTrait = new IsTrait(); $classDescription = (new ClassDescriptionBuilder()) ->setFilePath('src/Foo.php') @@ -21,10 +21,10 @@ public function test_it_should_return_violation_error(): void ->build(); $because = 'we want to add this rule for our software'; - $violationError = $isFinal->describe($classDescription, $because)->toString(); + $violationError = $isTrait->describe($classDescription, $because)->toString(); $violations = new Violations(); - $isFinal->evaluate($classDescription, $violations, $because); + $isTrait->evaluate($classDescription, $violations, $because); self::assertNotEquals(0, $violations->count()); self::assertEquals('HappyIsland should be trait because we want to add this rule for our software', $violationError); @@ -32,7 +32,7 @@ public function test_it_should_return_violation_error(): void public function test_it_should_return_true_if_is_trait(): void { - $isFinal = new IsTrait(); + $isTrait = new IsTrait(); $classDescription = (new ClassDescriptionBuilder()) ->setFilePath('src/Foo.php') @@ -42,7 +42,7 @@ public function test_it_should_return_true_if_is_trait(): void $because = 'we want to add this rule for our software'; $violations = new Violations(); - $isFinal->evaluate($classDescription, $violations, $because); + $isTrait->evaluate($classDescription, $violations, $because); self::assertEquals(0, $violations->count()); }