fix(query-builder): default alias for count('*') is no longer invalid SQL#14
Merged
Merged
Conversation
… SQL
`count('*')` without an explicit alias produced `as *_count`, which isn't
a valid SQL identifier:
SELECT COUNT(*) as *_count FROM users AS u
^^^^^^^^
syntax error near "*"
Default to the bare identifier `count` when the field is `*`; existing
behavior for non-star fields is preserved.
Caught while porting the QueryBuilder to phpnomad/sqlite-integration —
the SQLite port carries the same fix.
alexstandiford
force-pushed
the
fix/count-star-default-alias
branch
from
acab601 to
275a14a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`count('*')` without an explicit alias produces `as *_count`, which isn't a valid SQL identifier:
```
SELECT COUNT(*) as _count FROM users AS u
^^^^^^^^
syntax error near ""
```
This defaults to the bare identifier `count` when the field is `*`. Existing behavior for non-star fields (`field_count`, with the field name as prefix) is preserved.
Why this matters
Caught while porting the QueryBuilder to `phpnomad/sqlite-integration`. A test that called `->count('*')` without an alias produced a query that the engine rejected. The SQLite port carries the same fix.
Test plan