Skip to content

fix(query-builder): default alias for count('*') is no longer invalid SQL #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexstandiford merged 1 commit into from
May 26, 2026
Merged

fix(query-builder): default alias for count('*') is no longer invalid SQL #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/Builders/QueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,12 @@ public function sum(string $fieldToSum, ?string $alias = null)
/** @inheritDoc */
public function count(string $fieldToCount, ?string $alias = null)
{
$alias = $alias ?: $fieldToCount . '_count';
// Default alias is "<field>_count", with a special case for `*` —
// `*_count` isn't a valid SQL identifier and produces a syntax error
// when the query is executed.
if ($alias === null) {
$alias = $fieldToCount === '*' ? 'count' : $fieldToCount . '_count';
}

if($fieldToCount !== '*'){
$fieldToCount = $this->prependField($fieldToCount);
Expand Down
Loading