Prevent infinite recursion in AttributeReflectionFactory when an attribute references itself on its constructor

- Add `$currentlyResolving` tracking array to `AttributeReflectionFactory` to detect when an attribute class is already being resolved
- When recursion is detected, return the attribute with empty argument types instead of recursing infinitely
- Covers self-referencing attribute on constructor method, mutual recursion between two attribute classes, and self-referencing attribute on constructor parameter

Author: phpstan-bot

src/Reflection/AttributeReflectionFactory.php

@@ -18,6 +18,9 @@
 final class AttributeReflectionFactory
 {
 
+	/** @var array<string, true> */
+	private array $currentlyResolving = [];
+
 	public function __construct(
 		private InitializerExprTypeResolver $initializerExprTypeResolver,
 		private ReflectionProviderProvider $reflectionProviderProvider,
@@ -98,40 +101,51 @@ private function fromNameAndArgumentExpressions(string $name, array $arguments,
 			return null;
 		}
 
-		$constructor = $classReflection->getConstructor();
-		$parameters = $constructor->getOnlyVariant()->getParameters();
-		$namedArgTypes = [];
-		foreach ($arguments as $i => $argExpr) {
-			if (is_int($i)) {
-				if (isset($parameters[$i])) {
-					$namedArgTypes[$parameters[$i]->getName()] = $this->initializerExprTypeResolver->getType($argExpr, $context);
-					continue;
-				}
-				if (count($parameters) > 0) {
-					$lastParameter = array_last($parameters);
-					if ($lastParameter->isVariadic()) {
-						$parameterName = $lastParameter->getName();
-						if (array_key_exists($parameterName, $namedArgTypes)) {
-							$namedArgTypes[$parameterName] = TypeCombinator::union($namedArgTypes[$parameterName], $this->initializerExprTypeResolver->getType($argExpr, $context));
-							continue;
+		$className = $classReflection->getName();
+		if (isset($this->currentlyResolving[$className])) {
+			return new AttributeReflection($className, []);
+		}
+
+		$this->currentlyResolving[$className] = true;
+
+		try {
+			$constructor = $classReflection->getConstructor();
+			$parameters = $constructor->getOnlyVariant()->getParameters();
+			$namedArgTypes = [];
+			foreach ($arguments as $i => $argExpr) {
+				if (is_int($i)) {
+					if (isset($parameters[$i])) {
+						$namedArgTypes[$parameters[$i]->getName()] = $this->initializerExprTypeResolver->getType($argExpr, $context);
+						continue;
+					}
+					if (count($parameters) > 0) {
+						$lastParameter = array_last($parameters);
+						if ($lastParameter->isVariadic()) {
+							$parameterName = $lastParameter->getName();
+							if (array_key_exists($parameterName, $namedArgTypes)) {
+								$namedArgTypes[$parameterName] = TypeCombinator::union($namedArgTypes[$parameterName], $this->initializerExprTypeResolver->getType($argExpr, $context));
+								continue;
+							}
+							$namedArgTypes[$parameterName] = $this->initializerExprTypeResolver->getType($argExpr, $context);
 						}
-						$namedArgTypes[$parameterName] = $this->initializerExprTypeResolver->getType($argExpr, $context);
 					}
-				}
-				continue;
-			}
-
-			foreach ($parameters as $parameter) {
-				if ($parameter->getName() !== $i) {
 					continue;
 				}
 
-				$namedArgTypes[$i] = $this->initializerExprTypeResolver->getType($argExpr, $context);
-				break;
+				foreach ($parameters as $parameter) {
+					if ($parameter->getName() !== $i) {
+						continue;
+					}
+
+					$namedArgTypes[$i] = $this->initializerExprTypeResolver->getType($argExpr, $context);
+					break;
+				}
 			}
-		}
 
-		return new AttributeReflection($classReflection->getName(), $namedArgTypes);
+			return new AttributeReflection($className, $namedArgTypes);
+		} finally {
+			unset($this->currentlyResolving[$className]);
+		}
 	}
 
 }

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1584,6 +1584,12 @@ public function testBug9172(): void
 		$this->assertNotEmpty($errors);
 	}
 
+	public function testBug14707(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-14707.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return list<Error>

tests/PHPStan/Analyser/data/bug-14707.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14707;
+
+use Attribute;
+
+#[Attribute(Attribute::TARGET_METHOD)]
+class AttributeUsingItself
+{
+	#[AttributeUsingItself('hi')]
+	public function __construct(string $param) {}
+}
+
+#[Attribute(Attribute::TARGET_ALL)]
+class AttrA
+{
+	#[AttrB('world')]
+	public function __construct(string $param) {}
+}
+
+#[Attribute(Attribute::TARGET_ALL)]
+class AttrB
+{
+	#[AttrA('hello')]
+	public function __construct(string $param) {}
+}
+
+#[Attribute(Attribute::TARGET_ALL)]
+class SelfRefOnParam
+{
+	public function __construct(#[SelfRefOnParam('hello')] string $param) {}
+}