support nested concat

Author: staabm

src/Rules/Keywords/RequireFileExistsRule.php

@@ -54,7 +54,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$errors = [];
 		$usedMagicDirFallback = false;
-		$paths = $this->resolveFilePaths($node, $scope, $usedMagicDirFallback);
+		$paths = $this->resolveFilePaths($node->expr, $scope, $usedMagicDirFallback);
 
 		foreach ($paths as $path) {
 			$path = $path->getValue();
@@ -147,10 +147,9 @@ private function getErrorMessage(Include_ $node, string $filePath): IdentifierRu
 	/**
 	 * @return list<ConstantStringType>
 	 */
-	private function resolveFilePaths(Include_ $node, Scope $scope, bool &$magicDirFallback): array
+	private function resolveFilePaths(Expr $expr, Scope $scope, bool &$magicDirFallback): array
 	{
 		$magicDirFallback = false;
-		$expr = $node->expr;
 
 		if (!$expr instanceof Expr\BinaryOp\Concat) {
 			return $scope->getType($expr)->getConstantStrings();
@@ -166,7 +165,14 @@ private function resolveFilePaths(Include_ $node, Scope $scope, bool &$magicDirF
 			return $paths;
 		}
 
-		return $scope->getType($expr)->getConstantStrings();
+		$paths = [];
+		$rightPaths = $this->resolveFilePaths($expr->right, $scope, $magicDirFallback);
+		foreach ($this->resolveFilePaths($expr->left, $scope, $magicDirFallback) as $left) {
+			foreach ($rightPaths as $rightPath) {
+				$paths[] = new ConstantStringType($left->getValue() . $rightPath->getValue());
+			}
+		}
+		return $paths;
 	}
 
 	private function isInFileExists(Include_ $node, Scope $scope): bool

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleNoConstantPathTest.php

@@ -33,6 +33,10 @@ public function testBug12203NoConstantPath(): void
 				"Path in require_once() __DIR__ . '/../bug-12203-sure-does-not-exist.php' is not a file or it does not exist.",
 				6,
 			],
+			[
+				"Path in require_once() __DIR__ . '/' . \$path . '/' . \$file is not a file or it does not exist.",
+				10,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php

@@ -136,6 +136,10 @@ public function testBug12203(): void
 				"Path in require_once() __DIR__ . '/../bug-12203-sure-does-not-exist.php' is not a file or it does not exist.",
 				6,
 			],
+			[
+				"Path in require_once() __DIR__ . '/' . \$path . '/' . \$file is not a file or it does not exist.",
+				10,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Keywords/data/bug-12203.php

@@ -4,3 +4,7 @@
 
 require_once '../bug-12203-sure-does-not-exist.php';
 require_once __DIR__ . '/../bug-12203-sure-does-not-exist.php';
+
+$path = '..';
+$file = 'bug-12203-sure-does-not-exist.php';
+require_once __DIR__ . '/'. $path .'/'. $file;