Skip to content

Commit f8d7b8a

Browse files
phpstan-botclaude
authored andcommitted
Exclude property hooks test from lint and fix escaped mutant
- Add tests/PHPStan/Rules/Properties/data/bug-14457.php to make lint exclusion list (PHP 8.4 property hooks syntax) - Change !$prototype->isAbstract()->yes() to $prototype->isAbstract()->no() in OverridingPropertyRule — equivalent for PhpPropertyReflection (always returns Yes or No), but killable by TrinaryLogicMutator since the reversed mutation (->yes()) is caught by the abstract-overriding-abstract test case Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent eca863c commit f8d7b8a

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ lint:
139139
--exclude tests/PHPStan/Rules/Variables/data/bug-14349.php \
140140
--exclude tests/PHPStan/Rules/Variables/data/bug-14352.php \
141141
--exclude tests/PHPStan/Rules/Variables/data/bug-14351.php \
142+
--exclude tests/PHPStan/Rules/Properties/data/bug-14457.php \
142143
src tests
143144

144145
install-paratest:

src/Rules/Properties/OverridingPropertyRule.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public function processNode(Node $node, Scope $scope): array
178178
))->identifier('property.notWritable')->nonIgnorable()->build();
179179
}
180180
}
181-
if ($node->isAbstract() && !$prototype->isAbstract()->yes()) {
181+
if ($node->isAbstract() && $prototype->isAbstract()->no()) {
182182
foreach (['get', 'set'] as $hookType) {
183183
if (!$propertyReflection->hasHook($hookType) || !$prototype->hasHook($hookType)) {
184184
continue;

0 commit comments

Comments
 (0)