RequireFileExistsRule: enable __DIR__ only for bleeding edge

Author: staabm

conf/bleedingEdge.neon

@@ -16,6 +16,7 @@ parameters:
 		reportNestedTooWideType: false # tmp
 		assignToByRefForeachExpr: true
 		curlSetOptArrayTypes: true
+		magicDirInInclude: true
 		checkDateIntervalConstructor: true
 		reportMethodPurityOverride: true
 		checkDynamicConstantNameValues: true

conf/config.neon

@@ -43,6 +43,7 @@ parameters:
 		reportNestedTooWideType: false
 		assignToByRefForeachExpr: false
 		curlSetOptArrayTypes: false
+		magicDirInInclude: false
 		checkDateIntervalConstructor: false
 		reportMethodPurityOverride: false
 		checkDynamicConstantNameValues: false

conf/parametersSchema.neon

@@ -45,6 +45,7 @@ parametersSchema:
 		reportNestedTooWideType: bool()
 		assignToByRefForeachExpr: bool()
 		curlSetOptArrayTypes: bool()
+		magicDirInInclude: bool()
 		checkDateIntervalConstructor: bool()
 		reportMethodPurityOverride: bool()
 		checkDynamicConstantNameValues: bool()

src/Rules/Keywords/RequireFileExistsRule.php

@@ -37,6 +37,8 @@ public function __construct(
 		#[AutowiredParameter]
 		private string $currentWorkingDirectory,
 		private ExprPrinter $exprPrinter,
+		#[AutowiredParameter(ref: '%featureToggles.magicDirInInclude%')]
+		private bool $checkMagicDirInInclude,
 	)
 	{
 	}
@@ -151,6 +153,10 @@ private function resolveFilePaths(Expr $expr, Scope $scope, bool &$magicDirFallb
 	{
 		$magicDirFallback = false;
 
+		if (!$this->checkMagicDirInInclude) {
+			return $scope->getType($expr)->getConstantStrings();
+		}
+
 		if (!$expr instanceof Expr\BinaryOp\Concat) {
 			return $scope->getType($expr)->getConstantStrings();
 		}

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleNoConstantPathTest.php

@@ -19,6 +19,7 @@ protected function getRule(): Rule
 		return new RequireFileExistsRule(
 			$this->currentWorkingDirectory,
 			self::getContainer()->getByType(ExprPrinter::class),
+			true,
 		);
 	}
 

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php

@@ -24,6 +24,7 @@ protected function getRule(): Rule
 		return new RequireFileExistsRule(
 			$this->currentWorkingDirectory,
 			self::getContainer()->getByType(ExprPrinter::class),
+			true,
 		);
 	}