Skip to content

Commit 6a15043

Browse files
committed
Extending unit test for remove parameter issue
1 parent 7fe9df7 commit 6a15043

1 file changed

Lines changed: 31 additions & 3 deletions

File tree

src/test/java/picoded/dstack/struct/simple/StructSimple_DataObjectMap_test.java

Lines changed: 31 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -614,13 +614,41 @@ public void removeViaDataObject() {
614614
// Lets just rescycle old test for some dummy data
615615
basicTest();
616616

617+
// Lets get DataObject list
618+
DataObject[] oRes = null;
619+
assertNotNull(oRes = mtObj.query(null, null));
620+
assertTrue(oRes.length > 0);
621+
622+
// Lets get the first object
623+
DataObject testObject = oRes[0];
624+
String oid = testObject._oid();
625+
testObject.remove("num");
626+
testObject.remove("str_val");
627+
testObject.saveDelta();
628+
629+
// Get the object again
630+
DataObject changedObject = mtObj.get(oid);
631+
assertNotNull( changedObject );
632+
633+
// Check the respective value is null
634+
assertNull( changedObject.get("num") );
635+
assertNull( changedObject.get("str_val") );
636+
637+
}
638+
639+
@Test
640+
public void removeViaMetaOID() {
641+
642+
// Lets just rescycle old test for some dummy data
643+
basicTest();
644+
617645
// Lets get DataObject list
618646
DataObject[] oRes = null;
619647
assertNotNull(oRes = mtObj.query(null, null));
620648
assertTrue(oRes.length > 0);
621649

622650
// Lets remove one object
623-
mtObj.remove(oRes[0]);
651+
mtObj.remove(oRes[0]._oid());
624652

625653
// Lets query to make sure its removed
626654
DataObject[] qRes = null;
@@ -629,7 +657,7 @@ public void removeViaDataObject() {
629657
}
630658

631659
@Test
632-
public void removeViaMetaOID() {
660+
public void removePropertyForMetaObject() {
633661

634662
// Lets just rescycle old test for some dummy data
635663
basicTest();
@@ -640,7 +668,7 @@ public void removeViaMetaOID() {
640668
assertTrue(oRes.length > 0);
641669

642670
// Lets remove one object
643-
mtObj.remove(oRes[0]._oid());
671+
mtObj.remove(oRes[0]);
644672

645673
// Lets query to make sure its removed
646674
DataObject[] qRes = null;

0 commit comments

Comments
 (0)