From 6583b70f9167827f539a32a0a07198072b8f2004 Mon Sep 17 00:00:00 2001 From: Dennis Pfahlbusch Date: Fri, 7 Feb 2025 10:13:59 +0100 Subject: [PATCH 1/4] Adjust naming to match naming of other pimcore bundles Signed-off-by: Dennis Pfahlbusch --- composer.json | 2 +- doc/01_Installation.md | 2 +- ...ratorBundle.php => PimcoreNumberSequenceGeneratorBundle.php} | 2 +- src/Resources/config/doctrine_migrations.yml | 2 +- src/Resources/config/services.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) rename src/{NumberSequenceGeneratorBundle.php => PimcoreNumberSequenceGeneratorBundle.php} (92%) diff --git a/composer.json b/composer.json index b325009..a7aa273 100644 --- a/composer.json +++ b/composer.json @@ -23,7 +23,7 @@ "extra": { "pimcore": { "bundles": [ - "Pimcore\\Bundle\\NumberSequenceGeneratorBundle\\NumberSequenceGeneratorBundle" + "Pimcore\\Bundle\\NumberSequenceGeneratorBundle\\PimcoreNumberSequenceGeneratorBundle" ] } } diff --git a/doc/01_Installation.md b/doc/01_Installation.md index 8981cba..9a594d9 100644 --- a/doc/01_Installation.md +++ b/doc/01_Installation.md @@ -25,5 +25,5 @@ return [ 3) Install the bundle: ```bash -bin/console pimcore:bundle:install NumberSequenceGeneratorBundle +bin/console pimcore:bundle:install PimcoreNumberSequenceGeneratorBundle ``` \ No newline at end of file diff --git a/src/NumberSequenceGeneratorBundle.php b/src/PimcoreNumberSequenceGeneratorBundle.php similarity index 92% rename from src/NumberSequenceGeneratorBundle.php rename to src/PimcoreNumberSequenceGeneratorBundle.php index 504a424..7d7c21d 100644 --- a/src/NumberSequenceGeneratorBundle.php +++ b/src/PimcoreNumberSequenceGeneratorBundle.php @@ -18,7 +18,7 @@ use Pimcore\Extension\Bundle\AbstractPimcoreBundle; use Pimcore\Extension\Bundle\Traits\PackageVersionTrait; -class NumberSequenceGeneratorBundle extends AbstractPimcoreBundle +class PimcoreNumberSequenceGeneratorBundle extends AbstractPimcoreBundle { use PackageVersionTrait; diff --git a/src/Resources/config/doctrine_migrations.yml b/src/Resources/config/doctrine_migrations.yml index b33c3cb..ffc4ce9 100644 --- a/src/Resources/config/doctrine_migrations.yml +++ b/src/Resources/config/doctrine_migrations.yml @@ -1,3 +1,3 @@ doctrine_migrations: migrations_paths: - 'Pimcore\Bundle\NumberSequenceGeneratorBundle\Migrations': '@NumberSequenceGeneratorBundle/Migrations' \ No newline at end of file + 'Pimcore\Bundle\NumberSequenceGeneratorBundle\Migrations': '@PimcoreNumberSequenceGeneratorBundle/Migrations' \ No newline at end of file diff --git a/src/Resources/config/services.yml b/src/Resources/config/services.yml index 81d38dc..ab992c7 100644 --- a/src/Resources/config/services.yml +++ b/src/Resources/config/services.yml @@ -25,5 +25,5 @@ services: Pimcore\Bundle\NumberSequenceGeneratorBundle\Installer: public: true arguments: - $bundle: "@=service('kernel').getBundle('NumberSequenceGeneratorBundle')" + $bundle: "@=service('kernel').getBundle('PimcoreNumberSequenceGeneratorBundle')" From 86a06bd86124162b9157096b680651128e81bf20 Mon Sep 17 00:00:00 2001 From: Dennis Pfahlbusch Date: Fri, 7 Feb 2025 14:56:50 +0100 Subject: [PATCH 2/4] Add migration Signed-off-by: Dennis Pfahlbusch --- src/Migrations/Version20250207140849.php | 49 ++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 src/Migrations/Version20250207140849.php diff --git a/src/Migrations/Version20250207140849.php b/src/Migrations/Version20250207140849.php new file mode 100644 index 0000000..100d187 --- /dev/null +++ b/src/Migrations/Version20250207140849.php @@ -0,0 +1,49 @@ + Date: Fri, 7 Feb 2025 13:57:42 +0000 Subject: [PATCH 3/4] Apply php-cs-fixer changes --- src/Migrations/Version20250207140849.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Migrations/Version20250207140849.php b/src/Migrations/Version20250207140849.php index 100d187..02ef58a 100644 --- a/src/Migrations/Version20250207140849.php +++ b/src/Migrations/Version20250207140849.php @@ -17,7 +17,6 @@ use Doctrine\DBAL\Schema\Schema; use Doctrine\Migrations\AbstractMigration; -use Pimcore\Bundle\NumberSequenceGeneratorBundle\RandomGenerator; use Pimcore\Model\Tool\SettingsStore; /** From d1f43ed175ebb26a9c38960708719a5d6d056c60 Mon Sep 17 00:00:00 2001 From: Dennis Pfahlbusch Date: Fri, 28 Feb 2025 11:58:20 +0100 Subject: [PATCH 4/4] Adjust naming Signed-off-by: Dennis Pfahlbusch --- ...ension.php => PimcoreNumberSequenceGeneratorExtension.php} | 2 +- src/PimcoreNumberSequenceGeneratorBundle.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename src/DependencyInjection/{NumberSequenceGeneratorExtension.php => PimcoreNumberSequenceGeneratorExtension.php} (94%) diff --git a/src/DependencyInjection/NumberSequenceGeneratorExtension.php b/src/DependencyInjection/PimcoreNumberSequenceGeneratorExtension.php similarity index 94% rename from src/DependencyInjection/NumberSequenceGeneratorExtension.php rename to src/DependencyInjection/PimcoreNumberSequenceGeneratorExtension.php index fd8a11a..19e7a86 100644 --- a/src/DependencyInjection/NumberSequenceGeneratorExtension.php +++ b/src/DependencyInjection/PimcoreNumberSequenceGeneratorExtension.php @@ -26,7 +26,7 @@ * * @link http://symfony.com/doc/current/cookbook/bundles/extension.html */ -class NumberSequenceGeneratorExtension extends Extension implements PrependExtensionInterface +class PimcoreNumberSequenceGeneratorExtension extends Extension implements PrependExtensionInterface { public function load(array $configs, ContainerBuilder $container): void { diff --git a/src/PimcoreNumberSequenceGeneratorBundle.php b/src/PimcoreNumberSequenceGeneratorBundle.php index 349b74f..954225d 100644 --- a/src/PimcoreNumberSequenceGeneratorBundle.php +++ b/src/PimcoreNumberSequenceGeneratorBundle.php @@ -15,7 +15,7 @@ namespace Pimcore\Bundle\NumberSequenceGeneratorBundle; -use Pimcore\Bundle\NumberSequenceGeneratorBundle\DependencyInjection\NumberSequenceGeneratorExtension; +use Pimcore\Bundle\NumberSequenceGeneratorBundle\DependencyInjection\PimcoreNumberSequenceGeneratorExtension; use Pimcore\Extension\Bundle\AbstractPimcoreBundle; use Pimcore\Extension\Bundle\Traits\PackageVersionTrait; use Symfony\Component\DependencyInjection\Extension\ExtensionInterface; @@ -31,7 +31,7 @@ protected function getComposerPackageName(): string public function getContainerExtension(): ExtensionInterface { - return new NumberSequenceGeneratorExtension(); + return new PimcoreNumberSequenceGeneratorExtension(); } public function getInstaller(): Installer