Images bigger than 600px cannot be viewed by non-users

[dweiss96]

The current configuration inside public/js/editor.js rewrites the path of images wider than 600px to /admin/asset/get-image-thumbnail?id=<asset-id>&width=600&aspectratio=true. This is written to the HTML which causes the image to only be viewable on the website if you are logged in as an backend user.

This issue is only present after the backend user did a reload after the image upload. Up until then the path seems to be used directly.

Pimcore:

Browser with logged in backend user:

Browser without logged in backend user:

I do not know if there is a need for the 600px width limit other than having a workable width for large images.

[github-actions]

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

[erengy]

The problem seems to be because Quill wraps the img element inside a span.

This is what Pimcore expects:

<img pimcore_id="..." pimcore_type="asset" src="..." ... />

This is what gets saved by Quill:

<span pimcore_id="..." pimcore_type="asset"><img src="..." ...></span>

Pimcore\Tool\Text::extractPimcoreAttributes() method checks the pimcore_id and pimcore_type attributes of a and img elements. Since those attributes are moved to the span by Quill, Pimcore\Tool\Text::wysiwygText() method cannot replace the img element with the actual thumbnail.

[erengy]

Tried changing the scope of pimcore_id and pimcore_type attributors to Parchment.Scope.ANY for a generic solution, didn't work.

Overriding formats/image blot to allow for these attributes seems to work, though it's quite a bit of code for something simple, which likely needs to be repeated for formats/link.