Skip to content

chore: audit resource definitions for missing computed attributes #125

Description

@samir-gandhi

Summary

Each YAML resource definition should declare all computed: true attributes that the PingOne Terraform provider exposes and that the API actually returns in its list/get response.

During development of the outputs feature, api_key.value was found missing from pingone_davinci_application — it is a computed attribute on the provider but was absent from the definition, so it could not be exported or listed as an output path.

Work required

For each resource definition in definitions/pingone/, cross-reference the provider documentation against the declared attributes and add any computed: true attributes that are:

  1. Documented as computed on the provider resource
  2. Present in the API response (verifiable against the Go SDK struct)

Resources to audit:

  • pingone_davinci_application
  • pingone_davinci_connector_instance
  • pingone_davinci_flow
  • pingone_davinci_flow_deploy
  • pingone_davinci_flow_enable
  • pingone_davinci_application_flow_policy
  • pingone_davinci_variable

Acceptance criteria

  • Each definition's computed attributes match the provider docs
  • Any newly added attributes are verified to be present in the API response (nil values are harmless but uninformative)
  • go run ./tools/validate-definitions definitions/ passes
  • make test passes

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions