From 3ef01fa0f1a03edc1782067632ccce3b8bbb481b Mon Sep 17 00:00:00 2001 From: Ahmad Faraj Date: Sun, 5 Jul 2026 09:24:22 +0300 Subject: [PATCH] fix(pipedv1): use FindSlackGroups for group mentions in trigger-failed notification notifyDeploymentTriggerFailed assigns the groups list from FindSlackUsers, so configured Slack groups are never mentioned on trigger failure. The v0 piped counterpart uses FindSlackGroups here. Signed-off-by: Ahmad Faraj --- pkg/app/pipedv1/trigger/trigger.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/app/pipedv1/trigger/trigger.go b/pkg/app/pipedv1/trigger/trigger.go index 318b494fa7..aac7abaa6a 100644 --- a/pkg/app/pipedv1/trigger/trigger.go +++ b/pkg/app/pipedv1/trigger/trigger.go @@ -493,7 +493,7 @@ func (t *Trigger) notifyDeploymentTriggerFailed(app *model.Application, appCfg * var groups []string if n := appCfg.DeploymentNotification; n != nil { users = n.FindSlackUsers(model.NotificationEventType_EVENT_DEPLOYMENT_TRIGGER_FAILED) - groups = n.FindSlackUsers(model.NotificationEventType_EVENT_DEPLOYMENT_TRIGGER_FAILED) + groups = n.FindSlackGroups(model.NotificationEventType_EVENT_DEPLOYMENT_TRIGGER_FAILED) } t.notifier.Notify(model.NotificationEvent{