Merge pull request #7860 from plotly/cam/7174/remove-mapbox

chore: Remove deprecated Mapbox traces

Author: camdecoster

.github/workflows/ci.yml

@@ -269,7 +269,7 @@ jobs:
       - name: Run noCI tests
         uses: ./.github/actions/run-xvfb
         with:
-          run: ./tasks/noci_test.sh jasmine
+          run: npm run test-jasmine -- --tags=noCI,noCIdep --nowatch
 
   # ============================================================
   # Image baseline generation and comparison

CONTRIBUTING.md

@@ -432,7 +432,7 @@ Other methods used by some trace modules:
   selections.
 - `_module.convert`: Sometimes separated from `_module.plot` or `_module.calc` to convert the
   plotly.js settings to another framework e.g. to `gl-plot3d` for `gl3d` traces, to
-  `mapbox-gl` for `mapbox` traces. This split can make the logic easier to test.
+  `maplibre-gl` for `map` traces. This split can make the logic easier to test.
   If you make a `convert`, you should call it from either `calc` or `plot`.
 
 ## Coding style

devtools/test_dashboard/devtools.js

@@ -4,7 +4,6 @@
 
 var Fuse = require('fuse.js/dist/fuse.common.js');
 var mocks = require('../../build/test_dashboard_mocks.json');
-var credentials = require('../../build/credentials.json');
 var Lib = require('../../src/lib');
 
 require('./perf');
@@ -18,9 +17,6 @@ var Tabs = {
 
             // use local topojson files
             topojsonURL: "../../topojson/dist",
-            // register mapbox access token
-            // run `npm run preset` if you haven't yet
-            mapboxAccessToken: credentials.MAPBOX_ACCESS_TOKEN,
 
             // show all logs in console
             logging: 2

draftlogs/7860_remove.md

@@ -0,0 +1 @@
+- Remove `scattermapbox`, `choroplethmapbox`, `densitymapbox` trace types, the `mapbox` subplot, and the `mapboxAccessToken` config option [[#7860](https://github.com/plotly/plotly.js/pull/7860)]

lib/choroplethmapbox.js

@@ -34,9 +34,6 @@ Plotly.register([
     require('../src/traces/splom/strict'),
     require('../src/traces/parcoords/strict'),
     require('./parcats'),
-    require('./scattermapbox'),
-    require('./choroplethmapbox'),
-    require('./densitymapbox'),
     require('./scattermap'),
     require('./choroplethmap'),
     require('./densitymap'),

lib/densitymapbox.js

@@ -53,7 +53,6 @@ export type {
     AxisName,
     ButtonClickEvent,
     Icon,
-    Mapbox,
     ModeBarButton,
     ModeBarButtonAny,
     ModeBarDefaultButtons,

lib/index-mapbox.js

@@ -34,9 +34,6 @@ Plotly.register([
     require('./splom'),
     require('./parcoords'),
     require('./parcats'),
-    require('./scattermapbox'),
-    require('./choroplethmapbox'),
-    require('./densitymapbox'),
     require('./scattermap'),
     require('./choroplethmap'),
     require('./densitymap'),