Skip to content

Commit ed780af

Browse files
popematttgregg
andauthored
Apply suggestions from code review
Co-authored-by: Tyler Gregg <greggt@amazon.com>
1 parent f78507c commit ed780af

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

src/main/java/com/amazon/ion/bytecode/bin10/SymbolTableHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
2222
/**
2323
* Helper to generate Bytecode instructions for Ion 1.0 style symbol tables.
2424
*
25-
* We cannot meaningfully read a partial symbol table, si it seems a reasonable requirement that the entire symbol
25+
* We cannot meaningfully read a partial symbol table, so it seems a reasonable requirement that the entire symbol
2626
* table must be buffered before we generate bytecode for it. Therefore, this is re-usable for both continuable and
2727
* non-continuable bytecode generators.
2828
*

src/test/java/com/amazon/ion/bytecode/bin10/TypeIdHelperTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ import org.junit.jupiter.params.provider.CsvSource
1010

1111
class TypeIdHelperTest {
1212

13-
/*
14-
fun isVariableLength(typeId: Int): Boolean = typeId.and(LOW_NIBBLE_MASK) == VAR_LENGTH_LOW_NIBBLE
15-
*/
1613

1714
@ParameterizedTest
1815
@CsvSource(

0 commit comments

Comments
 (0)