Skip to content

Improve on laziness of package metadata reading during LSP startup #1265

@DavisVaughan

Description

@DavisVaughan

i noticed that test_rename_to_empty_name_returns_clean_error runs quite slow for me (like 5 seconds or so most of the time when the test is run in debug mode, the default)

it looks like set_library_paths -> scan_new_library_path can take a loooooooong time when you have quite a few packages, like 600 of them 😬

it does run faster in release mode, i.e. just test test_rename_to_empty_name_returns_clean_error --release runs in more like 1 second.

the problem seems to mostly be Air's parsing of 600 package NAMESPACE files, which I think we can probably do lazily and delay until required.

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions