Skip to content

Bug with nested HTML comments inside backquotes #518

@jaimeiniesta

Description

@jaimeiniesta

Hi, when some code inside backquotes contains HTML comments, it complains that backquotes are not closed, and the output is incorrect, see this example with Elixir 1.18 and earmark 1.4:

This is fine

iex(1)> m = "some source"
"some source"
iex(2)> Earmark.as_html!(m)
"<p>\nsome source</p>\n"

This is fine as well, backquotes are converted to inline code

iex(3)> m = "some source `2`"
"some source `2`"
iex(4)> Earmark.as_html!(m)
"<p>\nsome source <code class=\"inline\">2</code></p>\n"

But this fails

iex(5)> m = "some source `<!-- 2 -->`"
"some source `<!-- 2 -->`"
iex(6)> Earmark.as_html!(m)
<no file>:1: warning: Closing unclosed backquotes ` at end of input
"<!-- 2 -->\n<p>\n`</p>\n"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions