Teza Bid Adapter: initial release#14093
Conversation
…al tagid - Fix test parameter to default to 0 (false) instead of 1 - Fix AUCTION_PRICE macro regex by removing dollar sign - Make tagid optional in isBidRequestValid (only require account) - Add fallback logic to check tagid in ortb2Imp.tagid and ortb2Imp.ext.gpid Co-Authored-By: vadim@teza.ai <vadim.frolov@thank-u.org>
Teza Bid Adapter: initial release
|
can you pull master and you should get a reviewer assigned automatic |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db29cbd267
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tagid: tagid, | ||
| secure: 1, | ||
| banner: { format: sizesToFormat(sizes) }, | ||
| bidfloor: bid.params.bidfloor || 0.01, |
There was a problem hiding this comment.
The adapter sets imp.bidfloor only from bid.params.bidfloor (or a hardcoded default) and never calls bid.getFloor(), so floor rules from the Floors module are ignored. In auctions where publishers enable dynamic floors, this will send stale/too-low floors to Teza and can materially change win rates and revenue behavior.
Useful? React with 👍 / 👎.
| ext: { | ||
| ...(ortb2.user?.ext || {}), | ||
| consent: bidderRequest?.gdprConsent?.consentString, | ||
| eids |
There was a problem hiding this comment.
Writing user.ext.eids from eids here overwrites any ortb2.user.ext.eids merged just above. If publishers provide EIDs through ORTB2 first-party data and the first bid has no userIdAsEids, the request sends an empty EID list and drops identity signals for the entire auction request.
Useful? React with 👍 / 👎.
| ...ortb2.device, | ||
| ua: (typeof navigator !== 'undefined' ? navigator.userAgent : ''), | ||
| language: (typeof navigator !== 'undefined' ? navigator.language : undefined), | ||
| dnt: (typeof navigator !== 'undefined' && navigator.doNotTrack === '1') ? 1 : 0 |
There was a problem hiding this comment.
This assignment unconditionally recomputes device.dnt from navigator.doNotTrack, overriding ortb2.device.dnt that may be set by the caller. In cases where FPD explicitly sets DNT (or navigator is unavailable), the adapter can emit dnt: 0 incorrectly and send the wrong privacy preference downstream.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
navigator.doNotTrack is deprecated by w3c, you should not be calling it
|
Closing as stale, feel free to resubmit or reopen when you're ready to work on this again |
5 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This PR introduces a new Teza bid adapter for Prebid.js with comprehensive support for banner advertising.
Contact Information
Test Parameters
Other information
related prebid.github.io PR: prebid/prebid.github.io#6320