diff --git a/modules/alliance_gravityBidAdapter.md b/modules/alliance_gravityBidAdapter.md index 98a9e17a4e..5ebdd710c5 100644 --- a/modules/alliance_gravityBidAdapter.md +++ b/modules/alliance_gravityBidAdapter.md @@ -25,7 +25,7 @@ var adUnits = [ bids: [{ bidder: 'alliance_gravity', params: { - srid: "test-id" + placementId: "test-id" } }] }, diff --git a/modules/alliance_gravityBidAdapter.ts b/modules/alliance_gravityBidAdapter.ts index d4b6d02490..9f0aaf7179 100644 --- a/modules/alliance_gravityBidAdapter.ts +++ b/modules/alliance_gravityBidAdapter.ts @@ -16,7 +16,7 @@ const DEFAULT_GZIP_ENABLED = false; declare module '../src/adUnits' { interface BidderParams { - srid: string + placementId: string } } @@ -37,7 +37,7 @@ const converter = ortbConverter({ deepSetValue(imp, 'ext.dimensions.cssMaxW', slotEl.style?.maxWidth); deepSetValue(imp, 'ext.dimensions.cssMaxH', slotEl.style?.maxHeight); } - deepSetValue(imp, 'ext.prebid.storedrequest.id', bidRequest.params.srid); + deepSetValue(imp, 'ext.prebid.storedrequest.id', bidRequest.params.placementId); return imp; }, request(buildRequest, imps, bidderRequest, context) { @@ -46,7 +46,7 @@ const converter = ortbConverter({ }); const isBidRequestValid = (bid:BidRequest): boolean => { - if (!bid.params.srid || typeof bid.params.srid !== 'string' || bid.params.srid === '') { + if (!bid.params.placementId || typeof bid.params.placementId !== 'string' || bid.params.placementId === '') { return false; } return true; diff --git a/test/spec/modules/alliance_gravityBidAdapter_spec.js b/test/spec/modules/alliance_gravityBidAdapter_spec.js index 980b0d2b02..026c994136 100644 --- a/test/spec/modules/alliance_gravityBidAdapter_spec.js +++ b/test/spec/modules/alliance_gravityBidAdapter_spec.js @@ -31,28 +31,28 @@ describe('Alliance Gravity bid adapter tests', () => { } }); - it('No srid', () => { + it('No placementId', () => { bannerBid.params = {}; expect(spec.isBidRequestValid(bannerBid)).to.be.equal(false); }); - it('Invalid srid type (number)', () => { - bannerBid.params = { srid: 1234 }; + it('Invalid placementId type (number)', () => { + bannerBid.params = { placementId: 1234 }; expect(spec.isBidRequestValid(bannerBid)).to.be.equal(false); }); - it('Invalid srid type (object', () => { - bannerBid.params = { srid: {} }; + it('Invalid placementId type (object)', () => { + bannerBid.params = { placementId: {} }; expect(spec.isBidRequestValid(bannerBid)).to.be.equal(false); }); - it('Empty srid', () => { - bannerBid.params = { srid: '' }; + it('Empty placementId', () => { + bannerBid.params = { placementId: '' }; expect(spec.isBidRequestValid(bannerBid)).to.be.equal(false); }); - it('Valid srid', () => { - bannerBid.params = { srid: '12345' }; + it('Valid placementId', () => { + bannerBid.params = { placementId: '12345' }; expect(spec.isBidRequestValid(bannerBid)).to.be.equal(true); }); }); @@ -75,7 +75,7 @@ describe('Alliance Gravity bid adapter tests', () => { { bidder: 'alliance_gravity', params: { - srid: "12345" + placementId: "12345" }, adUnitCode: 'header-ad-1234', transactionId: '469a570d-f187-488d-b1cb-48c1a2009be9', @@ -87,7 +87,7 @@ describe('Alliance Gravity bid adapter tests', () => { { bidder: 'alliance_gravity', params: { - srid: '67890', + placementId: '67890', }, mediaTypes: { banner: {