From d8b6ec2f46e6902fe68cbe7677106c68b110db92 Mon Sep 17 00:00:00 2001 From: Danylo Date: Thu, 3 Apr 2025 16:03:48 +0200 Subject: [PATCH] Fix NPE --- .../prebid/server/bidder/kobler/KoblerBidder.java | 3 ++- .../server/bidder/kobler/KoblerBidderTest.java | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java b/src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java index 1595eee36e7..7053432ba38 100644 --- a/src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java +++ b/src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java @@ -10,6 +10,7 @@ import com.iab.openrtb.response.BidResponse; import com.iab.openrtb.response.SeatBid; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.BooleanUtils; import org.prebid.server.bidder.Bidder; import org.prebid.server.bidder.model.BidderBid; import org.prebid.server.bidder.model.BidderCall; @@ -126,7 +127,7 @@ private List normalizeCurrencies(BidRequest bidRequest) { private boolean isTest(Imp imp, List errors) { try { - return parseImpExt(imp).getTest(); + return BooleanUtils.isTrue(parseImpExt(imp).getTest()); } catch (PreBidException e) { errors.add(BidderError.badInput(e.getMessage())); return false; diff --git a/src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java b/src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java index 7864ea726b1..63a8d3ec56c 100644 --- a/src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java @@ -133,6 +133,21 @@ public void makeHttpRequestsShouldUseDefaultEndpointWhenTestModeDisabled() { .containsExactly(ENDPOINT_URL); } + @Test + public void makeHttpRequestsShouldUseDefaultEndpointWhenTestModeAbsent() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp( + imp -> imp.ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpKobler.of(null)))))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly(ENDPOINT_URL); + } + @Test public void makeHttpRequestsShouldAddUsdToCurrenciesIfMissing() { // given