From ac0eef1abd2ba9e0e72eb92e2f7f716c643e9687 Mon Sep 17 00:00:00 2001
From: antonbabak <ababak@magnite.com>
Date: Fri, 27 Jun 2025 11:04:14 +0200
Subject: [PATCH] Rubicon: Remove default maxbids value

---
 .../org/prebid/server/bidder/rubicon/RubiconBidder.java    | 5 ++---
 .../prebid/server/bidder/rubicon/RubiconBidderTest.java    | 7 ++-----
 .../it/openrtb2/magnite/test-magnite-bid-request.json      | 1 -
 .../it/openrtb2/rubicon/test-rubicon-bid-request.json      | 1 -
 4 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java b/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
index d66fd90adf5..5760b9f4242 100644
--- a/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
+++ b/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
@@ -890,15 +890,14 @@ private List<String> mapVendorsNamesToUrls(List<Metric> metrics) {
         return vendorsUrls.isEmpty() ? null : vendorsUrls;
     }
 
-    private Integer getMaxBids(ExtRequest extRequest) {
+    private static Integer getMaxBids(ExtRequest extRequest) {
         final ExtRequestPrebid extRequestPrebid = extRequest != null ? extRequest.getPrebid() : null;
         final List<ExtRequestPrebidMultiBid> multibids = extRequestPrebid != null
                 ? extRequestPrebid.getMultibid() : null;
         final ExtRequestPrebidMultiBid extRequestPrebidMultiBid =
                 CollectionUtils.isNotEmpty(multibids) ? multibids.getFirst() : null;
-        final Integer multibidMaxBids = extRequestPrebidMultiBid != null ? extRequestPrebidMultiBid.getMaxBids() : null;
 
-        return multibidMaxBids != null ? multibidMaxBids : 1;
+        return extRequestPrebidMultiBid != null ? extRequestPrebidMultiBid.getMaxBids() : null;
     }
 
     private String getGpid(ObjectNode impExt) {
diff --git a/src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java b/src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
index 49cb2a20e97..d85e94191a6 100644
--- a/src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
+++ b/src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
@@ -599,7 +599,7 @@ public void makeHttpRequestsShouldPassNativeBattrField() {
     }
 
     @Test
-    public void makeHttpRequestsShouldAddMaxbidsAttributeAsOneIfExtPrebidMultibidMaxBidsIsNotPresent() {
+    public void makeHttpRequestsShouldAddMaxbidsAttributeAsNullIfExtPrebidMultibidMaxBidsIsNotPresent() {
         // given
         final BidRequest bidRequest = givenBidRequest(
                 builder -> builder.ext(ExtRequest.of(ExtRequestPrebid.builder()
@@ -620,7 +620,7 @@ public void makeHttpRequestsShouldAddMaxbidsAttributeAsOneIfExtPrebidMultibidMax
                 .extracting(Imp::getExt).doesNotContainNull()
                 .extracting(ext -> mapper.treeToValue(ext, RubiconImpExt.class))
                 .extracting(RubiconImpExt::getMaxbids)
-                .containsExactly(1);
+                .containsOnlyNulls();
     }
 
     @Test
@@ -659,7 +659,6 @@ public void makeHttpRequestsShouldFillImpExt() {
                                 null,
                                 "uuid_bid_id"))
                         .skadn(givenSkadn)
-                        .maxbids(1)
                         .build());
     }
 
@@ -2445,7 +2444,6 @@ public void makeHttpRequestsShouldCreateRequestPerImp() {
                         .video(Video.builder().build())
                         .ext(mapper.valueToTree(RubiconImpExt.builder()
                                 .rp(expectedImpExtRp)
-                                .maxbids(1)
                                 .build()))
                         .build()))
                 .build();
@@ -2456,7 +2454,6 @@ public void makeHttpRequestsShouldCreateRequestPerImp() {
                         .ext(mapper.valueToTree(
                                 RubiconImpExt.builder()
                                         .rp(expectedImpExtRp)
-                                        .maxbids(1)
                                         .build()))
                         .build()))
                 .build();
diff --git a/src/test/resources/org/prebid/server/it/openrtb2/magnite/test-magnite-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/magnite/test-magnite-bid-request.json
index cb9ea650de8..37492413f7b 100644
--- a/src/test/resources/org/prebid/server/it/openrtb2/magnite/test-magnite-bid-request.json
+++ b/src/test/resources/org/prebid/server/it/openrtb2/magnite/test-magnite-bid-request.json
@@ -28,7 +28,6 @@
             "mint_version": ""
           }
         },
-        "maxbids": 1,
         "tid": "${json-unit.any-string}"
       }
     }
diff --git a/src/test/resources/org/prebid/server/it/openrtb2/rubicon/test-rubicon-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/rubicon/test-rubicon-bid-request.json
index cb9ea650de8..37492413f7b 100644
--- a/src/test/resources/org/prebid/server/it/openrtb2/rubicon/test-rubicon-bid-request.json
+++ b/src/test/resources/org/prebid/server/it/openrtb2/rubicon/test-rubicon-bid-request.json
@@ -28,7 +28,6 @@
             "mint_version": ""
           }
         },
-        "maxbids": 1,
         "tid": "${json-unit.any-string}"
       }
     }