New Adapter: Waardex#4563
Open
yegorWaardex wants to merge 32 commits into
Open
Conversation
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code coverage summaryNote:
waardexRefer here for heat map coverage report |
Contributor
|
You have mandatory adapter parameters that also need to be tested. From the documentation: Example of valid parameters for validation: var validParams = []json.RawMessage{
json.RawMessage(`{"zoneId": 101}`),
}Example of invalid parameters for validation: var invalidTypeParams = []json.RawMessage{
json.RawMessage(`{"zoneId": "101"}`), // String instead of integer
json.RawMessage(`{"zoneId": 1.5}`), // Float instead of integer
json.RawMessage(`{"zoneId": true}`), // Boolean instead of integer
json.RawMessage(`{"zoneId": []}`), // Array instead of integer
json.RawMessage(`{"zoneId": {}}`), // Object instead of integer
} |
| # Please deploy this config in each of your datacenters with the appropriate regional subdomain | ||
| endpoint: "http://REGION.justbidit2.xyz:8800/hb?zone={{.ZoneID}}" | ||
| maintainer: | ||
| email: it@waardex.com |
Contributor
There was a problem hiding this comment.
Sent verification email, please respond.
Author
There was a problem hiding this comment.
@pm-jaydeep-mohite We have not received the verification email. Could you please resend it? Thank you.
Contributor
There was a problem hiding this comment.
Email was confirmed
… remove unused error handling
…d improve structure consistency
…implify impression processing
…and improve existence check logic
Collaborator
|
@yegorWaardex please see comments above. |
Author
|
@bsardo Thanks for the reminder! I’ve applied the changes. Let me know what you think. |
Contributor
postindustria-code
left a comment
postindustria-code
left a comment
There was a problem hiding this comment.
After the latest changes prebid server can not start successfully, I am getting an error:
F0113 13:35:50.409712 92840 main.go:54] prebid-server failed: user sync (1 error):
1: cannot create syncer for bidder waardex with key waardex: redirect template: waardex_usersync_url:1:326: executing "waardex_usersync_url" at <.SspID>: can't evaluate field SspID in type macros.UserSyncPrivacy
Also the adapter endpoints are returning me a 403 error for both regions:
curl -i --location --request POST http://useast.justbidit2.xyz:8800/hb\?zone\=101
HTTP/1.1 403 Forbidden
vary: Origin
access-control-allow-credentials: true
content-length: 0
date: Tue, 13 Jan 2026 12:42:38 GMT
Code coverage summaryNote:
waardexRefer here for heat map coverage report |
Author
|
@postindustria-code I fixed the following bug: Also, please try this cURL: |
… invalid responses and malformed inputs
Code coverage summaryNote:
waardexRefer here for heat map coverage report |
Author
|
@postindustria-code Thank you for your review. The requested changes have been implemented. Please let me know your thoughts |
…ressions for same and different zones
Code coverage summaryNote:
waardexRefer here for heat map coverage report |
Author
|
@postindustria-code Thank you for your review. The requested changes have been implemented. Please let me know your thoughts |
Code coverage summaryNote:
waardexRefer here for heat map coverage report |
postindustria-code
approved these changes
Jan 30, 2026
przemkaczmarek
approved these changes
Feb 4, 2026
Collaborator
|
@yegorWaardex I'm just noticing now that this adapter looks very similar to adkernel. Is this a white label? If so, we require you to just create a single |
Collaborator
|
@yegorWaardex please see comment above. |
Collaborator
|
@yegorWaardex see above. |
Author
|
@bsardo Thanks for the review. Waardex is not a white label of adkernel — it's an independent adapter maintained by our team against our own exchange (waardex.com). Any resemblance is due to the shared OpenRTB 2.x patterns both adapters follow. An |
Collaborator
|
@yegorWaardex thanks for the response regarding aliases. Your adapter looks good, however, you'll need to merge with master and update all of the package references in your adapter to be v4. The package references changed when we released 4.0 a couple of months ago. Once that is complete we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prebid/prebid.github.io#6290