Skip to content

New Adapter: Nuba#4565

Merged
bsardo merged 10 commits into
prebid:masterfrom
nuba-io:master
Mar 20, 2026
Merged

New Adapter: Nuba#4565
bsardo merged 10 commits into
prebid:masterfrom
nuba-io:master

Conversation

@nuba-io
Copy link
Copy Markdown
Contributor

@nuba-io nuba-io commented Oct 10, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

doc MR: prebid/prebid.github.io#6295

Comment thread adapters/nuba/nuba.go Outdated
Comment thread adapters/nuba/nuba.go Outdated
Comment thread adapters/nuba/nuba.go Outdated
@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b9a4ba6

nuba

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84:	makeRequest		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:138:	getMediaTypeForImp	100.0%
total:								(statements)		92.2%

@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6c9d9f2

nuba

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84:	makeRequest		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:143:	getMediaTypeForImp	66.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:162:	getMediaTypeForBid	100.0%
total:								(statements)		87.5%

@bsardo bsardo added the adapter label Oct 16, 2025
@bsardo bsardo changed the title Nuba Bid Adapter: initial release New Adapter: Nuba Oct 28, 2025
@bsardo
Copy link
Copy Markdown
Collaborator

bsardo commented Oct 28, 2025

Hi @nuba-io, is this a white label solution? This looks very similar to the Compass adapter.

@nuba-io
Copy link
Copy Markdown
Contributor Author

nuba-io commented Nov 4, 2025

Hi @bsardo,
Yes, is a white label solution.
It may look similar to Compass, but it's a separate solution.

@nuba-io
Copy link
Copy Markdown
Contributor Author

nuba-io commented Nov 14, 2025

Hi, @bsardo @jney @minaguib @dlackty )
Do you have any other comments on PR?

@bsardo
Copy link
Copy Markdown
Collaborator

bsardo commented Nov 20, 2025

@nuba-io thanks for the response. Can you elaborate on why you're calling it a white label but also a separate solution? Prebid Server has strict guidelines that if an adapter is a white label, the aliasing feature should be used instead of copying an adapter. This significantly reduces review and maintenance time as it cuts the lines of code from 1k+ to ~20.

@nuba-io
Copy link
Copy Markdown
Contributor Author

nuba-io commented Nov 21, 2025

Hi, @bsardo
Thanks for raising this point — it’s a valid concern.
We’ve updated the PR to fully align with the white-label guidelines you mentioned. The implementation now uses the aliasing approach instead of duplicating the adapter, which keeps the code minimal and reduces the review and maintenance overhead.

If there’s anything else we should refine, happy to adjust.

@bsardo bsardo self-assigned this Dec 16, 2025
Comment thread static/bidder-info/nuba.yaml Outdated
@@ -0,0 +1,4 @@
aliasOf: "teqblaze"
endpoint: "https://ads.nuba.io/openrtb2/auction"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoint does not appear to be reachable

curl -i --location --request POST https://ads.nuba.io/
HTTP/1.1 404 Not Found
Content-Type: text/plain
Date: Sun, 11 Jan 2026 04:13:54 GMT
Connection: keep-alive
Keep-Alive: timeout=5
Content-Length: 0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the report. We’ve updated the endpoint and confirmed that it’s now reachable and working correctly.
curl -i --location --request POST https://ads.nuba.io/pserver
HTTP/1.1 204 No Content Access-Control-Allow-Origin: * Access-Control-Allow-Credentials: true Date: Mon, 12 Jan 2026 19:37:53 GMT Connection: keep-alive Keep-Alive: timeout=5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, all works

➜ curl -i --location --request POST https://ads.nuba.io/pserver
HTTP/1.1 204 No Content
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Date: Fri, 13 Feb 2026 09:40:23 GMT
Connection: keep-alive
Keep-Alive: timeout=5

Comment thread static/bidder-info/nuba.yaml Outdated
aliasOf: "teqblaze"
endpoint: "https://ads.nuba.io/openrtb2/auction"
maintainer:
email: "ssp@nuba.io"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've sent an email to this address. Please respond to the email with a message of received so we can verify it is reachable.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respond to the email. We've resent it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuba-io we resent the email again. Please respond so we can be sure the mailbox is reachable.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo I've sent mail to new email address, I'm waiting for response

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo @nuba-io email confirmed

image

@bsardo bsardo merged commit 5d6c775 into prebid:master Mar 20, 2026
4 checks passed
dxtech-git pushed a commit to dxtech-git/prebid-server that referenced this pull request Mar 25, 2026
t-sormonte pushed a commit to Viously/prebid-server-go that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants