Skip to content

Adagio: add Site to capabilities and correct error type#4595

Closed
linux019 wants to merge 1 commit into
prebid:masterfrom
linux019:update-adagio-adapter
Closed

Adagio: add Site to capabilities and correct error type#4595
linux019 wants to merge 1 commit into
prebid:masterfrom
linux019:update-adagio-adapter

Conversation

@linux019
Copy link
Copy Markdown
Contributor

@linux019 linux019 commented Nov 1, 2025

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 1, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 82312f6

adagio

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:27:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:51:	MakeBids	93.8%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/adagio/adagio.go:129:	getBidExt	100.0%
total:									(statements)	92.6%

@bsardo bsardo added the adapter label Nov 3, 2025
@osazos
Copy link
Copy Markdown
Contributor

osazos commented Nov 13, 2025

Hi @linux019,
#4590 was already opened for this purpose.
By the way, there was a specific reason we didn’t include the web capability (see #6327), so please avoid modifying our config file without checking with us first.

I acknowledge your point regarding the error type.

I suggest closing this PR and continuing with the initial one, #4590.

@linux019 linux019 closed this Nov 13, 2025
@linux019 linux019 deleted the update-adagio-adapter branch November 13, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants