From 14880eef8815303aef0a271e6cf329e51464769b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 23 Apr 2026 18:55:26 +0000 Subject: [PATCH 1/3] Initial plan From aa9dd560ed4371b43e56da95a0d35c23d3d27b96 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 23 Apr 2026 19:00:21 +0000 Subject: [PATCH 2/3] feat(build-images): authenticate in both org default registries Agent-Logs-Url: https://github.com/prefapp/firestarter-workflows/sessions/6957c57f-b95e-45bd-9e82-d961ad58fb34 Co-authored-by: alambike <1025564+alambike@users.noreply.github.com> --- firestarter/tests/test_build_images_functionality.py | 12 ++++++------ firestarter/workflows/build_images/build_images.py | 9 +++++++-- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/firestarter/tests/test_build_images_functionality.py b/firestarter/tests/test_build_images_functionality.py index 60171782..19ddde08 100644 --- a/firestarter/tests/test_build_images_functionality.py +++ b/firestarter/tests/test_build_images_functionality.py @@ -90,22 +90,22 @@ def execute_function_test(mocker, flavors, **kwargs) -> None: assert len(compile_images_for_all_flavors_mock.mock_calls) == kwargs["compile_image_calls"] execute_function_test( - mocker, "*", checkout_calls=1, login_calls=5, compile_image_calls=1 + mocker, "*", checkout_calls=1, login_calls=6, compile_image_calls=1 ) execute_function_test( - mocker, "flavor1, flavor3", checkout_calls=1, login_calls=5, compile_image_calls=1 + mocker, "flavor1, flavor3", checkout_calls=1, login_calls=6, compile_image_calls=1 ) execute_function_test( - mocker, "flavor2, flavor3", checkout_calls=1, login_calls=3, compile_image_calls=1 + mocker, "flavor2, flavor3", checkout_calls=1, login_calls=4, compile_image_calls=1 ) execute_function_test( - mocker, "flavor0, flavor4", checkout_calls=1, login_calls=1, compile_image_calls=1 + mocker, "flavor0, flavor4", checkout_calls=1, login_calls=2, compile_image_calls=1 ) execute_function_test( - mocker, "flavor1", checkout_calls=1, login_calls=3, compile_image_calls=1 + mocker, "flavor1", checkout_calls=1, login_calls=4, compile_image_calls=1 ) execute_function_test( - mocker, "", checkout_calls=1, login_calls=3, compile_image_calls=1 + mocker, "", checkout_calls=1, login_calls=4, compile_image_calls=1 ) diff --git a/firestarter/workflows/build_images/build_images.py b/firestarter/workflows/build_images/build_images.py index 10016775..466476c3 100644 --- a/firestarter/workflows/build_images/build_images.py +++ b/firestarter/workflows/build_images/build_images.py @@ -172,8 +172,13 @@ def execute(self): if self.login_required: self.login( self.auth_strategy, - default_registry, - default_registry_creds, + self.snapshots_registry, + self.snapshots_registry_creds, + ) + self.login( + self.auth_strategy, + self.releases_registry, + self.releases_registry_creds, ) for flavor in self.flavors: From 3b8a7a624f4f613960e7e86ddb25c455d034d1c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20G=C3=B3mez=20Rodr=C3=ADguez?= Date: Fri, 24 Apr 2026 10:53:04 +0200 Subject: [PATCH 3/3] fix: Update firestarter/workflows/build_images/build_images.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- firestarter/workflows/build_images/build_images.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/firestarter/workflows/build_images/build_images.py b/firestarter/workflows/build_images/build_images.py index 466476c3..72ef43b2 100644 --- a/firestarter/workflows/build_images/build_images.py +++ b/firestarter/workflows/build_images/build_images.py @@ -175,11 +175,12 @@ def execute(self): self.snapshots_registry, self.snapshots_registry_creds, ) - self.login( - self.auth_strategy, - self.releases_registry, - self.releases_registry_creds, - ) + if self.releases_registry != self.snapshots_registry: + self.login( + self.auth_strategy, + self.releases_registry, + self.releases_registry_creds, + ) for flavor in self.flavors: logger.info(f"Building flavor {flavor}...")