From 31f6a55ceee50baa8e10391abca85ee73e0526e0 Mon Sep 17 00:00:00 2001 From: Prell Date: Sat, 16 May 2026 09:41:36 -0500 Subject: [PATCH] fix(ship): i18n ship-repo-section literal strings (unblock main CI) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ROA-264 (#100) added ship-repo-section.tsx with raw JSX strings that trip i18next/no-literal-string — 4 hard eslint errors that turned @multica/views#lint red on main, failing every CI run since the merge. - Reuse existing project_summary.{ready,blocked,draft}_pill keys (already have {{count}} interpolation in en + zh-Hans). - Add a repo_section block (expand/collapse aria-labels + empty state) to both locale files so the parity test stays green. - Wire useT("ship") + the selector-form t($ => ...) calls. Verification: - pnpm -F @multica/views run lint -> exit 0 (was: 4 errors) - pnpm -F @multica/views typecheck -> clean - @multica/views test -> 652/652 pass (incl. locale parity) Co-Authored-By: Claude Opus 4.7 (1M context) Co-authored-by: multica-agent --- packages/views/locales/en/ship.json | 5 +++++ packages/views/locales/zh-Hans/ship.json | 5 +++++ packages/views/ship/components/ship-repo-section.tsx | 6 +++++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/views/locales/en/ship.json b/packages/views/locales/en/ship.json index 45ebea2872..5de37db4a5 100644 --- a/packages/views/locales/en/ship.json +++ b/packages/views/locales/en/ship.json @@ -66,6 +66,11 @@ "draft_title": "{{count}} draft", "no_prs": "No pull requests" }, + "repo_section": { + "expand": "Expand repo", + "collapse": "Collapse repo", + "empty": "No pull requests" + }, "kanban": { "drafted": "Drafted", "in_review": "In Review", diff --git a/packages/views/locales/zh-Hans/ship.json b/packages/views/locales/zh-Hans/ship.json index 4394ac76c1..a6583263bd 100644 --- a/packages/views/locales/zh-Hans/ship.json +++ b/packages/views/locales/zh-Hans/ship.json @@ -66,6 +66,11 @@ "draft_title": "{{count}} 个草稿", "no_prs": "暂无 PR" }, + "repo_section": { + "expand": "展开仓库", + "collapse": "折叠仓库", + "empty": "没有拉取请求" + }, "kanban": { "drafted": "草稿", "in_review": "审查中", diff --git a/packages/views/ship/components/ship-repo-section.tsx b/packages/views/ship/components/ship-repo-section.tsx index 33fd6f8d29..afe63847ea 100644 --- a/packages/views/ship/components/ship-repo-section.tsx +++ b/packages/views/ship/components/ship-repo-section.tsx @@ -55,7 +55,11 @@ export function ShipRepoSection({ className="flex size-5 shrink-0 items-center justify-center rounded hover:bg-muted" aria-expanded={!collapsed} aria-controls={sectionId} - aria-label={collapsed ? "Expand repo" : "Collapse repo"} + aria-label={ + collapsed + ? t(($) => $.repo_section.expand) + : t(($) => $.repo_section.collapse) + } >