Auto-link / Close Issues for 2.0 PRs (p5.js & p5.js-website)

[perminder-17]

Increasing access

GitHub’s auto‑link / auto‑close keywords (Resolves #123, Fixes #123, etc.) only work when a PR targets the default branch (main). For PRs into dev-2.0, the keywords are ignored. Example: p5.js PR #7971 included Resolves #7905 but the issue was not linked or closed. Same problem in p5.js-website PRs to 2.0 branch.

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• Build process
• Unit testing
• Internationalization
• Friendly errors
• Other (specify if possible)

Feature request details

Add a GitHub Action (workflow) that runs when a PR into dev-2.0 is merged in p5.js. (similar in p5.js-website with 2.0 branch) It should:

1. Parse the PR body for Resolves #issue-number.
2. Link the issue to that PR.
3. Close issues immediately when merged. (I think this step will be done by github after linking).

This action should be included in both the repo, i.e. p5.js and p5.js-website

[NalinDalal]

from what i understood i think I had to create a yaml file that would account for pull request created on 2.0 branch, hence i created one, but github has this feature by default only for main branch, hence created a automation for same via yml file

thank you

[NalinDalal]

pr: #7989

[ksen0]

Hi @NalinDalal , following up here after the Discord chat! Thanks for bumping the topic.

Related PRs: processing/p5.js-website#919 and #8025 (In these PRs and tin the future @NalinDalal , could you please make the title descriptive of the issue - like "Auto-close issues for 2.0 PRs" - and link the issue in the body of the PR, by writing "Addresses #..."? Thank you!)

Because this is not an urgent bugfix, I believe it should be only merged when it is ready. The current solution (although it works) introduces hard to maintain code into both repositories: the script inside the action itself, which is hard to coordinate between 2 repos. The process for improving this after merging would be, I believe, more complicated than the process of improving these PRs before merging them. In the future, I would recommend first describing the approach on the GitHub issue itself, for feedback before implementation.

Including @limzykenneth Discord comments for additional context:

We would like to go with a different approach, rather than using inline scripts which is hard to maintain and reuse, we would like to properly encapsulate the script in its own repo that the actions can use like any other action step.

I think in terms of procedure if we'd like this action to be available immediately we can merge the PR while we get the action step repo set up, otherwise we can wait until that is set up then push another commit to these PRs to use that repo's script instead, then we can merge after.

This means that the next step will be for @limzykenneth to set up the action step repo, and then @NalinDalal you can update the PRs. Although an implementation is needed on both p5.js and p5.js-website, to avoid duplicate work, I would suggest that you do this 1 PR at a time. For example, focus on the p5.js one, and then, once it's reviewed, finalized, and merged, update the p5.js-website one. What do you think @NalinDalal ?

Thanks for your patience!
cc @davepagurek @perminder-17