Error wav not playing

[NoSloppy]

referencing #849

I added wavs for these errors.
e_fnt_nf
e_vp_nf
e_blade
e_in_fnt
e_vp_ver
"Font directory not found" and "Error in font directory" are always spoken using talkie, but "Voice pack not found" and "Error in voice pack version" wavs are played.

Those are all I've tested so far.

[NoSloppy]

This is not being called in hybrid_font

    case EFFECT_FONT_DIRECTORY_NOT_FOUND:
        PlayErrorMessage("e_fnt_nf.wav");
        PVLOG_DEBUG << "***** SHOULD BE PLAYING Font Dir Not Found WAV HERE\n";
        break;

I moved it into an SB_Effect2 instead thinking that would help, still no dice.

[NoSloppy]

void ProffieOSErrors::font_directory_not_found() {
  SaberBase::DoEffect(EFFECT_FONT_DIRECTORY_NOT_FOUND, 0);
  PVLOG_ERROR << "** ERROR - Font directory not found.\n"
                 "** See https://pod.hubbe.net/troubleshooting/what-is-it-saying.html#font-directory-not-found\n";
#ifdef ENABLE_AUDIO
PVLOG_DEBUG  << "**** Font dir not found sound length = " << SaberBase::sound_length << "\n";
  if (SaberBase::sound_length > 0) return;
.....

19:42:33.652 -> **** Font dir not found sound length = 0.00

Sound length at the time of the check in errors.h is returning 0, so it's not picking up font.wav duration by that point... still looking.

[NoSloppy]

If we wait until after the call to SaberBase::Link(this); in Activate() to call the errors, it plays the wavs.
They still overlap though, but that's another conversation.

[profezzorn]

Hmm, it would seem we need to refactor something to make this work.

Choices include, but are not limited to:

• delay errors until after activate (or at least until SaberBase::Link)
• move up the hybrid font linking to before the scan.
• not rely on hybrid_font to play the errors, just play them directly from the error code
• keep hybrid font linked at all times (no link/unlink when activating/deactivating) Linking is basically a leftover from when there was two different classes monophonic and polyphonic fonts...
• something else that I haven't thought of yet....

I will look into more details tomorrow.

[NoSloppy]

I submitted a PR for this. Seems to work okay, but still the overlapping error messages when there are more than one is "cluttered".
Did we rule out just using sound library so they will queue up and play back to back?
I tried playing with that but the order of included files and such from hybrid font makes it not a simple call.