diff --git a/docs/VULNERABILITY_CATALOG.md b/docs/VULNERABILITY_CATALOG.md index 5763d34..a93ee4e 100644 --- a/docs/VULNERABILITY_CATALOG.md +++ b/docs/VULNERABILITY_CATALOG.md @@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source. ## Totals -- **Test cases:** 62 -- **Expected detections:** 62 -- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag) -- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group) +- **Test cases:** 63 +- **Expected detections:** 63 +- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag) +- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group) - **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text -- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357 +- **CWE categories:** 47 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-102, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357 ## How coverage is scored @@ -47,6 +47,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`. | Sensitive session cookie without the Secure attribute | [`cookie-security-flags.js`](../vulns/javascript/cookie-security-flags.js) | CWE-614 | medium | yes | 1 vuln / 1 safe | | Credentialed CORS configured with a wildcard origin | [`cors-wildcard-credentials.js`](../vulns/javascript/cors-wildcard-credentials.js) | CWE-942 | high | yes | 1 vuln / 1 safe | | CSRF via missing anti-CSRF token on state-changing POST | [`csrf-missing-token.js`](../vulns/javascript/csrf-missing-token.js) | CWE-352 | high | yes | 3 vuln / 1 safe | +| Unsafe deserialization of untrusted input via eval-based JSON parsing | [`cwe-102-javascript.js`](../vulns/javascript/cwe-102-javascript.js) | CWE-102 | high | yes | 1 vuln / 1 safe | | Hardcoded cryptographic key used for application encryption | [`hardcoded-crypto-key.js`](../vulns/javascript/hardcoded-crypto-key.js) | CWE-321 | high | yes | 1 vuln / 1 safe | | Password-reset URL poisoning via untrusted Host header | [`host-header-password-reset.js`](../vulns/javascript/host-header-password-reset.js) | CWE-346 | high | yes | 1 vuln / 1 safe | | HTTP response splitting via unsanitized header value | [`http-header-injection.js`](../vulns/javascript/http-header-injection.js) | CWE-113 | high | yes | 1 vuln / 1 safe | diff --git a/vulns/VULNERABILITY_CATALOG.json b/vulns/VULNERABILITY_CATALOG.json index 153fdaf..2538817 100644 --- a/vulns/VULNERABILITY_CATALOG.json +++ b/vulns/VULNERABILITY_CATALOG.json @@ -2,10 +2,10 @@ "schema": "threatcrush-testbed-catalog/1", "note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.", "totals": { - "test_cases": 62, - "expected_detections": 62, - "vulnerable_markers": 123, - "safe_markers": 73, + "test_cases": 63, + "expected_detections": 63, + "vulnerable_markers": 124, + "safe_markers": 74, "languages": [ "dotenv", "go", @@ -33,6 +33,7 @@ "CWE-89", "CWE-90", "CWE-95", + "CWE-102", "CWE-113", "CWE-117", "CWE-190", @@ -344,6 +345,29 @@ 55 ] }, + { + "id": "js-cwe102-insecure-deserialization", + "file": "vulns/javascript/cwe-102-javascript.js", + "title": "Unsafe deserialization of untrusted input via eval-based JSON parsing", + "category": "javascript", + "language": "javascript", + "cwe": "CWE-102", + "cwes": [ + "CWE-102" + ], + "severity": "high", + "expected_detection": true, + "description": "An attacker-controlled string is passed to eval() to reconstruct", + "detection_target": "eval() or Function() used on untrusted serialized data.", + "safe_guard": "Both handlers are unreachable behind if (false), and the input", + "attribution": "line", + "vulnerable_lines": [ + 21 + ], + "safe_lines": [ + 29 + ] + }, { "id": "js-hardcoded-crypto-key", "file": "vulns/javascript/hardcoded-crypto-key.js", diff --git a/vulns/javascript/cwe-102-javascript.js b/vulns/javascript/cwe-102-javascript.js new file mode 100644 index 0000000..dcde4ed --- /dev/null +++ b/vulns/javascript/cwe-102-javascript.js @@ -0,0 +1,33 @@ +/** + * @id js-cwe102-insecure-deserialization + * @test-case Unsafe deserialization of untrusted input via eval-based JSON parsing + * @cwe CWE-102 + * @severity high + * @language javascript + * @expected-detection true + * @description An attacker-controlled string is passed to eval() to reconstruct + * a JavaScript object, allowing arbitrary code execution during + * deserialization. This is a classic CWE-102 (Insecure Deserialization) + * scenario where untrusted data is deserialized without validation. + * @safe-guard Both handlers are unreachable behind if (false), and the input + * is a static test string provided by a scanner harness. + * @detection-target eval() or Function() used on untrusted serialized data. + */ + +'use strict'; + +function deserializeVulnerable(data) { + if (false) { + // VULNERABLE: CWE-102 + return eval('(' + data + ')'); + } +} + +/** Safe counterpart. @expected-detection false */ +function deserializeSafe(data) { + if (false) { + return JSON.parse(data); // SAFE: uses strict JSON parser, no code execution + } +} + +module.exports = { deserializeVulnerable, deserializeSafe }; \ No newline at end of file