From 7c9f1c8bc4009cacf72871985c6acea869c535d0 Mon Sep 17 00:00:00 2001 From: CSTRSK Date: Sun, 9 Aug 2026 08:12:15 +0000 Subject: [PATCH] test-cases: add CWE-129 (go) --- docs/VULNERABILITY_CATALOG.md | 11 ++++--- vulns/VULNERABILITY_CATALOG.json | 32 +++++++++++++++++--- vulns/go/cwe-129-go.go | 52 ++++++++++++++++++++++++++++++++ 3 files changed, 86 insertions(+), 9 deletions(-) create mode 100644 vulns/go/cwe-129-go.go diff --git a/docs/VULNERABILITY_CATALOG.md b/docs/VULNERABILITY_CATALOG.md index 5763d34..972b164 100644 --- a/docs/VULNERABILITY_CATALOG.md +++ b/docs/VULNERABILITY_CATALOG.md @@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source. ## Totals -- **Test cases:** 62 -- **Expected detections:** 62 -- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag) -- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group) +- **Test cases:** 63 +- **Expected detections:** 63 +- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag) +- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group) - **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text -- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357 +- **CWE categories:** 47 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-129, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357 ## How coverage is scored @@ -27,6 +27,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`. | Test case | File | CWE | Severity | Expected | Markers | |---|---|---|---|---|---| | OS command injection via exec.Command with a shell | [`cmd-injection-exec.go`](../vulns/go/cmd-injection-exec.go) | CWE-78 | critical | yes | 2 vuln / 1 safe | +| CWE-129 improper validation of array index from HTTP request | [`cwe-129-go.go`](../vulns/go/cwe-129-go.go) | CWE-129 | high | yes | 1 vuln / 1 safe | | Integer overflow and unchecked narrowing conversion | [`integer-overflow.go`](../vulns/go/integer-overflow.go) | CWE-190 | medium | yes | 2 vuln / 3 safe | | SQL injection via fmt.Sprintf | [`sqli-fmt-sprintf.go`](../vulns/go/sqli-fmt-sprintf.go) | CWE-89 | critical | yes | 2 vuln / 1 safe | | Server-side request forgery via http.Get on a user-supplied URL | [`ssrf-http-get.go`](../vulns/go/ssrf-http-get.go) | CWE-918 | high | yes | 2 vuln / 2 safe | diff --git a/vulns/VULNERABILITY_CATALOG.json b/vulns/VULNERABILITY_CATALOG.json index 153fdaf..916f6f5 100644 --- a/vulns/VULNERABILITY_CATALOG.json +++ b/vulns/VULNERABILITY_CATALOG.json @@ -2,10 +2,10 @@ "schema": "threatcrush-testbed-catalog/1", "note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.", "totals": { - "test_cases": 62, - "expected_detections": 62, - "vulnerable_markers": 123, - "safe_markers": 73, + "test_cases": 63, + "expected_detections": 63, + "vulnerable_markers": 124, + "safe_markers": 74, "languages": [ "dotenv", "go", @@ -35,6 +35,7 @@ "CWE-95", "CWE-113", "CWE-117", + "CWE-129", "CWE-190", "CWE-201", "CWE-209", @@ -99,6 +100,29 @@ 46 ] }, + { + "id": "go-cwe129-array-index", + "file": "vulns/go/cwe-129-go.go", + "title": "CWE-129 improper validation of array index from HTTP request", + "category": "go", + "language": "go", + "cwe": "CWE-129", + "cwes": [ + "CWE-129" + ], + "severity": "high", + "expected_detection": true, + "description": "User-controlled query parameter is used directly as an array", + "detection_target": "Taint flow from request input into a slice index operation", + "safe_guard": "Guarded by the always-false `neverRun` constant plus an `ignore`", + "attribution": "line", + "vulnerable_lines": [ + 35 + ], + "safe_lines": [ + 47 + ] + }, { "id": "go-integer-overflow", "file": "vulns/go/integer-overflow.go", diff --git a/vulns/go/cwe-129-go.go b/vulns/go/cwe-129-go.go new file mode 100644 index 0000000..202c2be --- /dev/null +++ b/vulns/go/cwe-129-go.go @@ -0,0 +1,52 @@ +// @id go-cwe129-array-index +// @test-case CWE-129 improper validation of array index from HTTP request +// @cwe CWE-129 +// @severity high +// @language go +// @expected-detection true +// @description User-controlled query parameter is used directly as an array +// index without bounds checking, leading to a potential panic +// (index out of range) or out-of-bounds read. The vulnerable +// function accesses a slice with the raw integer value from the +// request, which can crash the application or expose unintended +// data. +// @safe-guard Guarded by the always-false `neverRun` constant plus an `ignore` +// build tag; no request is ever processed. +// @detection-target Taint flow from request input into a slice index operation +// without prior bounds validation. +// +// NEVER RUN IN PRODUCTION — intentional test case for scanner validation. + +//go:build ignore + +package vulns + +import ( + "net/http" + "strconv" +) + +var dataStore = []string{"alpha", "beta", "gamma", "delta"} + +func getItemVulnerable(r *http.Request) (string, error) { + if neverRun { + idxStr := r.URL.Query().Get("index") // SOURCE: attacker-controlled + idx, _ := strconv.Atoi(idxStr) // conversion without validation + return dataStore[idx], nil // VULNERABLE: CWE-129 + } + return "", nil +} + +// getItemSafe is the safe counterpart — the scanner should NOT flag this. +// @expected-detection false +func getItemSafe(r *http.Request) (string, error) { + if neverRun { + idxStr := r.URL.Query().Get("index") // SOURCE + idx, err := strconv.Atoi(idxStr) + if err != nil || idx < 0 || idx >= len(dataStore) { + return "", nil // SAFE: bounds check before indexing + } + return dataStore[idx], nil + } + return "", nil +} \ No newline at end of file