Skip to content

Fix GetToponymsByStreetcodeIdHandler #43

@PenultimateBoss

Description

@PenultimateBoss

GetToponymsByStreetcodeIdHandler.Handle method does not return Result.Fail when no toponyms are found.

Image

According to IRepositoryBase interface, method GetAllAsync can`t return null, so check for null in if expression (line 34) is useless. Instead, better check if collection is empty.

Image

Additional remarks:

  1. Line 33 do basically nothing and partially copy logic of line 41. Suggest to just remove it;

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions