[BUG] Missing nil check for opts in js/compiler/pool/executeWithRuntime

[wooffie]

Is there an existing issue for this?

• I have searched the existing issues.

Current Behavior

Missed nil check for setting opts.ExecutionId -

nuclei/pkg/js/compiler/pool.go

Line 115 in 3497738

runtime.SetContextValue("executionId", opts.ExecutionId)

Before always checked opts, so I think it can be nil

Expected Behavior

Checking for nil

Steps To Reproduce

Create run without opts

Relevant log output

Environment

Current dev branch

Anything else?

If opts cannot be nil remove another checks...

[dwisiswant0]

so I think it can be nil

Could you share a concrete example that opts ever reaches executeWithRuntime as nil in any realistic execution path that is not vague nor hand-wavy? e.g. a template + exact nuclei command that crashes here, or a custom runner PoC? Thanks!

[github-actions]

This issue has been automatically closed due to inactivity. If you think this is a mistake or would like to continue the discussion, please comment or feel free to reopen it.