Skip to content

Commit 93fa503

Browse files
jaydelucaclaude
jaydeluca
and
claude
committed
chore: move narrowly-used test deps out of root pom (#2146)
The root `pom.xml` was declaring `junit-pioneer`, `awaitility`, `wiremock`, and `guava` (test scope) as global test dependencies, adding them to the classpath of all 24 core modules. Each is only actually needed by 1–3 modules. Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
1 parent 2cc68fc commit 93fa503

6 files changed

Lines changed: 78 additions & 30 deletions

File tree

  • integration-tests/it-exporter/it-exporter-test
  • pom.xml
  • prometheus-metrics-config
  • prometheus-metrics-core
  • prometheus-metrics-exporter-opentelemetry-shaded
  • prometheus-metrics-exporter-opentelemetry

‎integration-tests/it-exporter/it-exporter-test/pom.xml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,11 @@
2323
<version>${project.version}</version>
2424
<scope>test</scope>
2525
</dependency>
26+
<dependency>
27+
<groupId>com.google.guava</groupId>
28+
<artifactId>guava</artifactId>
29+
<version>${guava.version}</version>
30+
<scope>test</scope>
31+
</dependency>
2632
</dependencies>
2733
</project>

‎pom.xml‎

Lines changed: 3 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
<automatic.module.name>--module-name-need-to-be-overridden--</automatic.module.name>
2323
<protobuf-java.version>4.35.0</protobuf-java.version>
2424
<guava.version>33.6.0-jre</guava.version>
25+
<junit-pioneer.version>2.3.0</junit-pioneer.version>
26+
<awaitility.version>4.3.0</awaitility.version>
27+
<wiremock.version>3.13.2</wiremock.version>
2528
<junit-jupiter.version>6.0.3</junit-jupiter.version>
2629
<otel.instrumentation.version>2.28.1-alpha</otel.instrumentation.version>
2730
<java.version>8</java.version>
@@ -92,42 +95,12 @@
9295
<version>3.27.7</version>
9396
<scope>test</scope>
9497
</dependency>
95-
<dependency>
96-
<groupId>com.google.guava</groupId>
97-
<artifactId>guava</artifactId>
98-
<version>${guava.version}</version>
99-
<scope>test</scope>
100-
</dependency>
10198
<dependency>
10299
<groupId>org.slf4j</groupId>
103100
<artifactId>slf4j-simple</artifactId>
104101
<version>2.0.18</version>
105102
<scope>test</scope>
106103
</dependency>
107-
<dependency>
108-
<groupId>org.junit-pioneer</groupId>
109-
<artifactId>junit-pioneer</artifactId>
110-
<version>2.3.0</version>
111-
<scope>test</scope>
112-
</dependency>
113-
<dependency>
114-
<groupId>org.awaitility</groupId>
115-
<artifactId>awaitility</artifactId>
116-
<version>4.3.0</version>
117-
<scope>test</scope>
118-
</dependency>
119-
<dependency>
120-
<groupId>org.wiremock</groupId>
121-
<artifactId>wiremock</artifactId>
122-
<version>3.13.2</version>
123-
<scope>test</scope>
124-
<exclusions>
125-
<exclusion>
126-
<groupId>org.hamcrest</groupId>
127-
<artifactId>hamcrest-core</artifactId>
128-
</exclusion>
129-
</exclusions>
130-
</dependency>
131104
</dependencies>
132105

133106
<build>

‎prometheus-metrics-config/pom.xml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,13 @@
2020
<automatic.module.name>io.prometheus.metrics.config</automatic.module.name>
2121
</properties>
2222

23+
<dependencies>
24+
<dependency>
25+
<groupId>org.junit-pioneer</groupId>
26+
<artifactId>junit-pioneer</artifactId>
27+
<version>${junit-pioneer.version}</version>
28+
<scope>test</scope>
29+
</dependency>
30+
</dependencies>
31+
2332
</project>

‎prometheus-metrics-core/pom.xml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,17 @@
5050
<version>3.6.1</version>
5151
<scope>test</scope>
5252
</dependency>
53+
<dependency>
54+
<groupId>org.awaitility</groupId>
55+
<artifactId>awaitility</artifactId>
56+
<version>${awaitility.version}</version>
57+
<scope>test</scope>
58+
</dependency>
59+
<dependency>
60+
<groupId>com.google.guava</groupId>
61+
<artifactId>guava</artifactId>
62+
<version>${guava.version}</version>
63+
<scope>test</scope>
64+
</dependency>
5365
</dependencies>
5466
</project>

‎prometheus-metrics-exporter-opentelemetry-shaded/pom.xml‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,30 @@
9494
<artifactId>opentelemetry-sdk-testing</artifactId>
9595
<scope>test</scope>
9696
</dependency>
97+
<dependency>
98+
<groupId>org.wiremock</groupId>
99+
<artifactId>wiremock</artifactId>
100+
<version>${wiremock.version}</version>
101+
<scope>test</scope>
102+
<exclusions>
103+
<exclusion>
104+
<groupId>org.hamcrest</groupId>
105+
<artifactId>hamcrest-core</artifactId>
106+
</exclusion>
107+
</exclusions>
108+
</dependency>
109+
<dependency>
110+
<groupId>org.awaitility</groupId>
111+
<artifactId>awaitility</artifactId>
112+
<version>${awaitility.version}</version>
113+
<scope>test</scope>
114+
</dependency>
115+
<dependency>
116+
<groupId>com.google.guava</groupId>
117+
<artifactId>guava</artifactId>
118+
<version>${guava.version}</version>
119+
<scope>test</scope>
120+
</dependency>
97121
</dependencies>
98122
</profile>
99123
</profiles>

‎prometheus-metrics-exporter-opentelemetry/pom.xml‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,30 @@
9595
<artifactId>opentelemetry-sdk-testing</artifactId>
9696
<scope>test</scope>
9797
</dependency>
98+
<dependency>
99+
<groupId>org.wiremock</groupId>
100+
<artifactId>wiremock</artifactId>
101+
<version>${wiremock.version}</version>
102+
<scope>test</scope>
103+
<exclusions>
104+
<exclusion>
105+
<groupId>org.hamcrest</groupId>
106+
<artifactId>hamcrest-core</artifactId>
107+
</exclusion>
108+
</exclusions>
109+
</dependency>
110+
<dependency>
111+
<groupId>org.awaitility</groupId>
112+
<artifactId>awaitility</artifactId>
113+
<version>${awaitility.version}</version>
114+
<scope>test</scope>
115+
</dependency>
116+
<dependency>
117+
<groupId>com.google.guava</groupId>
118+
<artifactId>guava</artifactId>
119+
<version>${guava.version}</version>
120+
<scope>test</scope>
121+
</dependency>
98122
</dependencies>
99123
</profile>
100124
</profiles>

0 commit comments

Comments
 (0)