prplmesh-hostapd: added disable_all_ap_vaps()

added functionality to disable all vaps that
are access-points (as opposed to STA for example).
the code mimics the existing functionality taken from
ap_wlan_hal_dwpal.cpp.
added funcvtionlity and unit test
note:
the example unit-test configuration file did not
contain any vap with the mode= line, therefore it
was added few of this.
also:
it was discovered that it is OK to look for non-exiting key
within vap's configuration and the code was changed accordingly

Signed-off-by: Ran Regev <ran.regev@devalore.com>

Author: RanRegev

common/beerocks/hostapd/configuration.cpp

@@ -159,6 +159,7 @@ std::string Configuration::get_vap_value(const std::string &vap, const std::stri
     if (existing_vap == m_hostapd_config_vaps.end()) {
         m_last_message = std::string(__FUNCTION__) + " couldn't find requested vap: " + vap +
                          " (requested key: " + key + ")";
+        // it is an error to ask for non existing vap
         m_ok = false;
         return "";
     }
@@ -173,7 +174,9 @@ std::string Configuration::get_vap_value(const std::string &vap, const std::stri
     if (it_str == existing_vap->second.end()) {
         m_last_message = std::string(__FUNCTION__) +
                          " couldn't find requested key for vap: " + vap + "; requested key: " + key;
-        m_ok = false;
+
+        // it ok not to find the requested key
+        m_ok = true;
         return "";
     }
 
@@ -182,6 +185,17 @@ std::string Configuration::get_vap_value(const std::string &vap, const std::stri
     return it_str->substr(key_eq.length());
 }
 
+void Configuration::disable_all_ap_vaps() {
+    for_each(
+            m_hostapd_config_vaps.begin(),
+            m_hostapd_config_vaps.end(),
+            [this](const std::pair<std::string, std::vector<std::string>> &vap) {
+                if ( get_vap_value(vap.first, "mode") == "ap" ) {
+                    set_create_vap_value(vap.first, "start_disabled", "1");
+                }
+            });
+}
+
 const std::string &Configuration::get_last_message() const { return m_last_message; }
 
 std::ostream &operator<<(std::ostream &o, const Configuration &conf)

common/beerocks/hostapd/include/configuration.h

@@ -86,6 +86,13 @@ class Configuration {
      */
     std::string get_vap_value(const std::string &vap, const std::string &key);
 
+    /**
+     * @brief disable all ap vaps
+     * @details disable all vaps that thier mode is "ap", 
+     * (leaving STAs vaps untouched for example)
+     */
+    void disable_all_ap_vaps();
+
     /**
      * @brief for debug: return the last internal message
      * @details each action on this class changes its internal

common/beerocks/hostapd/unit_tests/configuration_test.cpp

@@ -152,8 +152,31 @@ TEST(configuration_test, get_vap_values)
     EXPECT_EQ(value, "") << conf;
 
     //// end test ////
+}
+
+
+TEST(configuration_test, diable_all_ap)
+{
+    //// start prerequsite ////
+
+    // construct a configuration
+    prplmesh::hostapd::config::Configuration conf(configuration_file);
+    ASSERT_FALSE(conf) << conf;
+
+    // load the dummy configuration file
+    conf.load();
+    ASSERT_TRUE(conf) << conf;
+
+    //// end prerequsite ////
 
-    // for humans
-    std::cerr << "received value: " << value << '\n';
+    //// start test ////
+    
+    conf.disable_all_ap_vaps();    
+    EXPECT_TRUE(conf) << conf;
+
+    conf.store();
+    EXPECT_TRUE(conf) << conf;
+
+    //// end test ////
 }
 } // namespace

common/beerocks/hostapd/unit_tests/hostapd.exmaple.conf

@@ -46,6 +46,7 @@ interworking=1
 disassoc_low_ack=1
 preamble=1
 wmm_enabled=1
+mode=ap
 ignore_broadcast_ssid=0
 uapsd_advertisement_enabled=1
 mbo=1
@@ -79,6 +80,7 @@ mesh_mode=fAP
 multi_ap_backhaul_ssid="Multi-AP-24G-2"
 multi_ap_backhaul_wpa_passphrase=maprocks2
 bss=wlan0.1
+mode=non-ap
 ctrl_interface=/var/run/hostapd
 ap_isolate=1
 ap_max_inactivity=60
@@ -148,4 +150,5 @@ wpa=0
 bridge=br-lan
 bssid=02:9A:96:FB:59:14
 start_disabled=1
+mode=ap