Stop upgrading plugins to the latest core branch#957
Merged
Conversation
The upgrade strategy when the dependecy on core is newer than any supported branch, should be to just wait until eventually one of the newer branches is declared supported. If we keep upgrading the dependency aggressively, we will likely miss the window to relax on a later supported branch.
ggainey
approved these changes
May 5, 2025
| updated, new_requirement = scan_requirement(requirement, supported_versions) | ||
| if updated: | ||
| new_requirement = scan_requirement(requirement, supported_versions) | ||
| if new_requirement is not None: |
|
|
||
| core_template = yaml.safe_load(request.content) | ||
| supported_versions = {parse(v) for v in core_template["supported_release_branches"]} | ||
| latest = core_template["latest_release_branch"] |
Contributor
There was a problem hiding this comment.
and this is the key that will keep us from updating to latest-released over and over until a new supported is added. got it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade strategy when the dependecy on core is newer than any supported branch, should be to just wait until eventually one of the newer branches is declared supported. If we keep upgrading the dependency aggressively, we will likely miss the window to relax on a later supported branch.