automatically run black on files we update via templates

[evgeni]

sometimes filling in a template leads to black changes (when an URL makes a line too long, for example), so lets fix that directly when generating, avoiding a second "black" commit

[evgeni]

This is especially annoying when the resulting diff (update ci + black) is +0-0 because the only changes that happened are "regenerate a .py file, making a line non-black compliant" followed by "black".

[mdellweg]

I like the idea. Is it evaluating settings in pyproject.toml here?

[evgeni]

As pwd is the template checkout, not the plugin checkout, probably not. Should I try to make it to?

[mdellweg]

In case of the bootstrap, we might not yet have it.
So better to make sure we get the same config somewhere else.

[mdellweg]

Or just run black on everything after all the templates.

[evgeni]

How? :)
But in the case of bootstrap, it will be fixed in a single "black" commit at some point and everything is good (again).

Updated the code to use cwd=plugin_root, so it should pickup the settings (untested)

[evgeni]

I was trying to avoid blacking files that do not come from a template, so that the "update CI files" commit is really that: CI files, not "ooh look, new black rule, let's refactor half of your repo"

[mdellweg]

Well, someone/thing needs to do it...

[mdellweg]

Maybe after all that was the reason to have it in a separate commit.

[evgeni]

That (generic) thing is

plugin_template/scripts/update_ci.sh

Lines 43 to 55 in 26877f9

	if [[ "${use_black}" == "True" ]]
	then
	pip install -r lint_requirements.txt
	black .
	if [[ "$(git status --porcelain)" ]]
	then
	git add -A
	git commit -m "Reformat with black"
	else
	echo "No formatting change needed"
	fi
	fi

[evgeni]

Hah, but posting this, I realized, black might not (yet) be installed when plugin-template runs

[evgeni]

Mhh, that... broke lint :D

[evgeni]

I'm reasonably happy with the result.

[mdellweg]

I believe i convinced myself, that this is what we want. ;)