[bp/3.39] Pin pycares to avoid bug with aiodns combination#6699
Merged
mdellweg merged 2 commits intoJul 7, 2025
Conversation
pedro-psb
force-pushed
the
patchback/backports/3.39/b1560306741816770ddafa3d51dadbef4c7b072a/pr-6697
branch
from
285769b to
239c8d5
Compare
mdellweg
force-pushed
the
patchback/backports/3.39/b1560306741816770ddafa3d51dadbef4c7b072a/pr-6697
branch
from
239c8d5 to
e226c1a
Compare
pedro-psb
force-pushed
the
patchback/backports/3.39/b1560306741816770ddafa3d51dadbef4c7b072a/pr-6697
branch
5 times, most recently
from
8ae7b6b to
b8e21ff
Compare
pedro-psb
commented
Jul 3, 2025
| fi | ||
|
|
||
| CI_IMAGE="ghcr.io/pulp/pulp-ci-centos" # get dynamically in plugin-template | ||
| CONTAINER_PYTHON_VERSION="$(docker run --rm $CI_IMAGE python3 --version | awk '{print $2}')" |
Member
Author
There was a problem hiding this comment.
This could be done in github workflow level (workflows/test.yml) and passed as an environment variable.
Or maybe there is a better way of getting this?
mdellweg
reviewed
Jul 4, 2025
mdellweg
reviewed
Jul 4, 2025
| if requirement.name == "pulpcore": | ||
| # An exception to allow for pulpcore deprecation policy. | ||
| return fetch_pulpcore_upper_bound(requirement) | ||
| # check python scope. E.g 'foo==1.0.0;python_version>=3.9' |
Member
There was a problem hiding this comment.
Actually I would be OK with
if requirement.marker:
return "# Skipping because environmental conditions are untrackable."
Member
Author
|
Added the change on plugin_template (without the python-version aware feature, for simplicity): pulp/plugin_template#971 |
pedro-psb
force-pushed
the
patchback/backports/3.39/b1560306741816770ddafa3d51dadbef4c7b072a/pr-6697
branch
from
a41a3f3 to
9f3c844
Compare
mdellweg
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See for more context:
#6695
(cherry picked from commit b156030)