free output array and median heap on window==1 in move_median#571
Merged
Conversation
neutrinoceros
approved these changes
Jun 3, 2026
neutrinoceros
left a comment
neutrinoceros
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thank you !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move_median allocates its output array with PyArray_EMPTY in INIT, then both dtype variants take an early return when window is 1. The float variant frees the median heap there but leaks that output array; the integer variant leaks both the array and the heap because it never calls mm_free either. I noticed it reading the two siblings side by side. Repeated calls with window=1 leak an input-sized array every time, so it accumulates fast. Free the array and the heap before returning, matching the normal exit path.