Restored called to expanduser in do_edit() instead of relying on do_shell() to do it.

This should prevent issues if someone has an overridden do_shell() that doesn't expand ~ in paths.

Author: kmvanbrunt

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.9.10 (February 22, 2019)
+* Bug Fixes
+    * Fixed unit test that hangs on Windows
+
 ## 0.9.9 (February 21, 2019)
 * Bug Fixes
     * Fixed bug where the ``set`` command was not tab completing from the current ``settable`` dictionary.

cmd2/cmd2.py

@@ -3356,9 +3356,9 @@ def do_edit(self, args: argparse.Namespace) -> None:
         if not self.editor:
             raise EnvironmentError("Please use 'set editor' to specify your text editing program of choice.")
 
-        command = utils.quote_string_if_needed(self.editor)
+        command = utils.quote_string_if_needed(os.path.expanduser(self.editor))
         if args.file_path:
-            command += " " + utils.quote_string_if_needed(args.file_path)
+            command += " " + utils.quote_string_if_needed(os.path.expanduser(args.file_path))
 
         self.do_shell(command)