Migrate away from deprecated jQuery APIs

Author: str4d

codespeed/static/js/changes.js

@@ -60,7 +60,7 @@ function updateTable() {
             permalinkToTimeline($(this).children("td:eq(0)").text(), environment);
         })
         //Add hover effect to rows
-        .on("hover", "tr", function() {
+        .on("mouseenter mouseleave", "tr", function() {
             $(this).toggleClass("highlight");
         });
 
@@ -118,10 +118,10 @@ function init(defaults) {
     $("#trend").val(defaults.trend);
     $("#trend").change(refreshContent);
 
-    $("#executable" + defaults.executable).attr('checked', true);
+    $("#executable" + defaults.executable).prop('checked', true);
     $("input[name='executable']").change(changeRevisions);
 
-    $("#env" + defaults.environment).attr('checked', true);
+    $("#env" + defaults.environment).prop('checked', true);
     $("input[name='environment']").change(refreshContent);
 
     $("#revision").html(revisionboxes[defaults.project]);

codespeed/static/js/comparison.js

@@ -389,21 +389,21 @@ function init(defaults) {
     // Set default values
     $("#chart_type").val(defaults.chart_type);
     $("#baseline").val(defaults.baseline);
-    $("#direction").attr("checked", defaults.direction === "True");
+    $("#direction").prop('checked', defaults.direction === "True");
 
     var sel = $("input[name='executables']");
     $.each(defaults.executables, function(i, exe) {
-        sel.filter("[value='" + exe + "']").attr('checked', true);
+        sel.filter("[value='" + exe + "']").prop('checked', true);
     });
 
     sel = $("input[name='benchmarks']");
     $.each(defaults.benchmarks, function(i, bench) {
-        sel.filter("[value='" + bench + "']").attr('checked', true);
+        sel.filter("[value='" + bench + "']").prop('checked', true);
     });
 
     sel = $("input[name='environments']");
     $.each(defaults.environments, function(i, env) {
-        sel.filter("[value='" + env + "']").attr('checked', true);
+        sel.filter("[value='" + env + "']").prop('checked', true);
     });
 
     $("#chart_type, #baseline, #direction, input[name='executables']," +

codespeed/static/js/timeline.js

@@ -212,7 +212,7 @@ function render(data) {
       $("#plotgrid").append('<div id="' + plotid + '" class="miniplot"></div>');
       $("#" + plotid).click(function() {
         var benchid = $(this).attr("id").slice(5);
-        $("#benchmark_" + benchid).attr('checked', true);
+        $("#benchmark_" + benchid).prop('checked', true);
         updateUrl();
       });
       renderMiniplot(plotid, data.timelines[bench]);
@@ -264,7 +264,7 @@ function setValuesOfInputFields(event) {
   // Either set the default value, or the one parsed from the url
 
   // Reset all checkboxes
-  $("input:checkbox").removeAttr('checked');
+  $("input:checkbox").prop('checked', false);
 
   $("#revisions").val(valueOrDefault(event.parameters.revs, defaults.revisions));
   $("#baseline").val(valueOrDefault(event.parameters.base, defaults.baseline));
@@ -274,28 +274,28 @@ function setValuesOfInputFields(event) {
   var sel = $("input[name='executable']");
 
   $.each(executables, function(i, exe) {
-    sel.filter("[value='" + exe + "']").attr('checked', true);
+    sel.filter("[value='" + exe + "']").prop('checked', true);
   });
 
   // Set default selected branches
   var branches = event.parameters.bran ? event.parameters.bran.split(',') : defaults.branches;
   sel = $("input[name='branch']");
 
   $.each(branches, function(i, b) {
-    sel.filter("[value='" + b + "']").attr('checked', true);
+    sel.filter("[value='" + b + "']").prop('checked', true);
   });
 
   // Set default selected benchmark
   var benchmark = valueOrDefault(event.parameters.ben, defaults.benchmark);
   $("input:radio[name='benchmark']")
       .filter("[value='" + benchmark + "']")
-      .attr('checked', true);
+      .prop('checked', true);
 
   // Set default selected environment
   var environment = valueOrDefault(event.parameters.env, defaults.environment);
   $("input:radio[name='environments']")
       .filter("[value='" + environment + "']")
-      .attr('checked', true);
+      .prop('checked', true);
 
   // Add color legend to executable list
   $("#executable div.boxbody > ul > ul > li > input").each(function() {
@@ -305,7 +305,7 @@ function setValuesOfInputFields(event) {
   });
 
   $("#baselinecolor").css("background-color", baselineColor);
-  $("#equidistant").attr('checked', valueOrDefault(event.parameters.equid, defaults.equidistant) === "on");
+  $("#equidistant").prop('checked', valueOrDefault(event.parameters.equid, defaults.equidistant) === "on");
 }
 
 function init(def) {