Skip to content

Commit 45e58e2

Browse files
jaracoclaude
andauthored
Pass continue-on-error to the reusable workflow as an input. (jaraco/skeleton#209)
A job that calls a reusable workflow may not set 'continue-on-error'; GitHub rejects the whole file at startup ("Unexpected value 'continue-on-error'") before creating any jobs. The reusable-workflow refactor in jaraco/skeleton#199 moved the 'test' job to a reusable-workflow call while keeping the job-level 'continue-on-error', taking CI dark on skeleton and every downstream project that has since merged. Move the setting into test-suite.yml as a boolean 'continue-on-error' input and pass it through from the caller, preserving the allow-3.15-to-fail behavior while keeping the version-specific logic in main.yml. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent f7aefdf commit 45e58e2

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/main.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ jobs:
4343
with:
4444
python: ${{ matrix.python }}
4545
platform: ${{ matrix.platform }}
46-
# https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error
47-
continue-on-error: ${{ matrix.python == '3.15' }}
46+
# continue-on-error can't be set on a reusable-workflow caller job
47+
# (jaraco/skeleton#199), so pass it through as an input instead.
48+
continue-on-error: ${{ matrix.python == '3.15' }}
4849

4950
collateral:
5051
strategy:

.github/workflows/test-suite.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ on:
1616
Tox environment to run; if empty, runs default tox
1717
type: string
1818
default: ""
19+
continue-on-error:
20+
description: >-
21+
Whether a failure of this run should be tolerated
22+
(e.g. for pre-release Pythons)
23+
type: boolean
24+
default: false
1925

2026
env:
2127
# Environment variable to support color support (jaraco/skeleton#66)
@@ -32,6 +38,7 @@ env:
3238
jobs:
3339
run:
3440
runs-on: ${{ inputs.platform }}
41+
continue-on-error: ${{ inputs.continue-on-error }}
3542
permissions:
3643
contents: read
3744
steps:

0 commit comments

Comments
 (0)