[BUG] workflow: unresolved placeholders in check.yml break runnable flow

[JuanVqz]

Type

Bug

Priority

P2

Severity

Medium

Component

workflow

Description

The workflow file includes unresolved placeholders (RUBY_VERSION, BUNDLER_VERSION, _BUNDLER_VERSION_) in executable steps.

Environment

• Repo: railsbump/checker
• Workflow: .github/workflows/check.yml

Actual Result

Workflow is not runnable as a real check pipeline with placeholders left as literals.

Expected Result

All workflow runtime values are concrete or interpolated from inputs/secrets.

Impact/Risk

Confusing and non-functional workflow execution path.

Acceptance Criteria

1. No unresolved placeholder literals remain in executable workflow steps.
2. Workflow can run successfully when dispatched.

Definition of Done

1. Fix merged.
2. Tests/validation updated as needed.
3. Ticket linked to PR.

References

• .github/workflows/check.yml

[JuanVqz]

@jeremysmithco To me this workflow is not used at all, and we might likely want to remove it.

[jeremysmithco]

@JuanVqz Thanks yeah, that's the conclusion I'm reaching as well.

This workflow existed at the very beginning of the repo and appears to be the original way of resolving dependencies.

It was replaced in railsbump/app#84

Here's the direct reference to the workflow:
https://github.com/railsbump/app/pull/84/changes#diff-55aafa07c41d85e43fd55f5545fa7ba5879885f4b09409f147eec682f9a2d16eL182

Apparently, the RailsBump app would:

• Check out a branch of the checker repo named after the compat ID
• Replace RUBY_VERSION and BUNDLER_VERSION
• Build a Gemfile out of the dependencies and a specific version of Rails
• Push the branch to trigger the check.yml workflow (originally, it was triggered on push rather than workflow_dispatch)

Then the check.yml workflow would:

• Install the appropriate version of Ruby and Bundler
• Generate a Gemfile.lock and insert the contents into the job summary
• On completion, GitHub would send a webhook notification back to the RailsBump app

Here are the things I'd like to do next:

• Confirm that the webhook notifications have been disabled for this workflow (someone with admin rights on this repo will have to check that)
• Remove this check.yml workflow file altogether
• Remove the reference to this workflow in the RailsBump app README
• Determine if the GitHub notifications endpoint in the RailsBump app is still necessary (it may be, I just haven't investigated that app fully yet)

Does all that make sense? Do you know who would have admin rights on the repo to check the webhook notifications configuration?

[JuanVqz]

@jeremysmithco That checklist makes sense to me.

Also, if you can include in the list an initiative for docs/ or even in the README.md to add the workflow you described (which is where I've driven as well but now using .github/workflows/check_bundler.yml):

Apparently, the RailsBump app would:

Check out a branch of the checker repo named after the compat ID
Replace RUBY_VERSION and BUNDLER_VERSION
Build a Gemfile out of the dependencies and a specific version of Rails
Push the branch to trigger the check.yml workflow (originally, it was triggered on push rather than workflow_dispatch)

[jeremysmithco]

@JuanVqz Thanks! Do you know who has admin rights to the repo to see what webhooks are setup? I'd like to confirm that removing the check.yml workflow file won't cause any problems.

[JuanVqz]

@JuanVqz Thanks! Do you know who has admin rights to the repo to see what webhooks are setup? I'd like to confirm that removing the check.yml workflow file won't cause any problems.

I just got granted if you want, we can pair tomorrow

[jeremysmithco]

@JuanVqz Awesome! 🙏 Let me know when is good for you!

[JuanVqz]

Part of this investigation was updating the readme at the rails bump app railsbump/app#151

I'll let you move this task to done; I'm unsure if this task is finished with that.

[jeremysmithco]

@JuanVqz Hey thanks. I think I'm stuck at this point because I'm not sure how to confirm for certain that webhook notifications have been disabled for the check.yml workflow. I have access to the settings for this repo now (thank you) but I can't see anything related to webhook configuration. Either my access is too limited or I don't know where to look. I would have expected it would be in the nav on the left under webhooks, like the docs say.

The other thing is that I've forgotten twice now (when pairing with you, and then Mateus on Heroku stuff) to take a look at the RailsBump app GitHubNotification records. I wanted to confirm that there haven't been any new records created any time recently. If so, then I think we can remove the GitHubNotification controller endpoint in the RailsBump app. (That could also be a separate issue, but it is related to this one.)

[jeremysmithco]

@JuanVqz I think, based on our investigation, we can plan to remove the GitHub notification endpoint, as we found no uses of it in the logs and no records for it. But it might be good to make a separate issue for removing that once we turn off webhook notifications.