Assign form attributes

[vad4msiu]

I have form:

class Forms::Publishers::CreateForm < ActiveForm::Base
  attributes :name
  validates :name, presence: true
end

Then in a controller I submit params:

form = Forms::Publishers::CreateForm.new(publisher)
form.submit(params)

But if params contain not name key (example: foo) I have error: NoMethodError: undefined method foo=' for #Forms::Publishers::CreateForm:0x007f85805f70a0. It force my to use params.slice(...)orstrong_parameters` gem. Why not just ignore attributes which don't defined? I thought form should receive any params but assign only defined?

[m-Peter]

You're correct. The functionality you describe is the desired. I'll work on it.

[kaspth]

Actually I think how it works currently is the desired way. Library users are expected to use strong parameters.

cc @guilleiguaran

[andrey-skat]

@kaspth Why to use strong parameters if you are using form objects? We already list all allowed attributes in attributes of ActiveForm. Why we need duplicate these attributes in controller?

[vad4msiu]

👍 I agree with the comment above

[kaspth]

I don't mind the duplication concern expressed here as I'm not DRY religious (not saying you are).

To me it feels odd that a form specifies its accepted attributes. Rails moved away from attr_accessible and this kind of introduces it again. That's part of a controller and why Strong Parameters was added.

On the other hand, specifying attributes does bring a certain clarity to the form.

What do you think, @m-Peter?

[andrey-skat]

attr_accessible and attributes in form object it's not the same thing.

I concerned about duplication not because DRY, but because keeping in sync many attributes between form and controller bored.

[m-Peter]

I share the same opinion with @andrey-skat . I had a hard time trying to setup the nested hierarchy nature that strong_parameters require.

[m-Peter]

There is a WIP in this commit: 8e847e7 . Let me know your thoughts about it.

[kaspth]

@andrey-skat I know they functionally aren't the same, but effectively they are for what we're talking about.

@m-Peter I've left some comments for you on that linked commit.

[m-Peter]

@kaspth Thanks for your help! I've applied them and will update the commit.