-
Project repository must be private and access should be granted upon request.
-
You have created gitignore file but did not use it properly.
-
Documentation in your readme file is good. you included your tech stack and the screenshot of your system and it's functions, that is also good. You can also try to mention the steps required to run your project. It will be super helpful.
-
Database and files which contains sql queries should contain extension .sql not .txt.
-
Commit messages must be meaningful and should display your relevant work done.
-
Remove unnecessary packages, folders and files which is of no use that will help you in removing redundancy.
-
Opened resources should be closed. for example, you have created scanner for taking input, but after taking input, you are not closing it.
-
Database secrets should not be there in the code.
-
Functionality wise and Feature wise you did good. You can still add more functionality and by using code modularity and local and global scope, you can make your code resuable if required.
-
Follow the coding and naming standards wherever required. It will help you improve your project structure.
Overall, you did well. Keep it up.
Project repository must be private and access should be granted upon request.
You have created gitignore file but did not use it properly.
Documentation in your readme file is good. you included your tech stack and the screenshot of your system and it's functions, that is also good. You can also try to mention the steps required to run your project. It will be super helpful.
Database and files which contains sql queries should contain extension .sql not .txt.
Commit messages must be meaningful and should display your relevant work done.
Remove unnecessary packages, folders and files which is of no use that will help you in removing redundancy.
Opened resources should be closed. for example, you have created scanner for taking input, but after taking input, you are not closing it.
Database secrets should not be there in the code.
Functionality wise and Feature wise you did good. You can still add more functionality and by using code modularity and local and global scope, you can make your code resuable if required.
Follow the coding and naming standards wherever required. It will help you improve your project structure.
Overall, you did well. Keep it up.