fix: guard curl_share_close() against PHP 8.5 deprecation

vinayshah · claude · vinayshah · commit da27b50d2940 · 2026-06-24T19:55:04.000+05:30
curl_share_close() is a no-op since PHP 8.0 and deprecated in PHP 8.5.
Skip the call on PHP 8+ to avoid deprecation notices.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/QuickChart.php b/QuickChart.php
@@ -51,7 +51,10 @@ function __construct($options = array()) {
 
   function __destruct() {
     if ($this->_curlShare !== null) {
-      curl_share_close($this->_curlShare);
+      // curl_share_close() is a no-op since PHP 8.0 and deprecated in PHP 8.5
+      if (PHP_MAJOR_VERSION < 8) {
+        curl_share_close($this->_curlShare);
+      }
       $this->_curlShare = null;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,10 @@ function __construct($options = array()) {`
`51`	`51`
`52`	`52`	`function __destruct() {`
`53`	`53`	`if ($this->_curlShare !== null) {`
`54`		`- curl_share_close($this->_curlShare);`
	`54`	`+ // curl_share_close() is a no-op since PHP 8.0 and deprecated in PHP 8.5`
	`55`	`+ if (PHP_MAJOR_VERSION < 8) {`
	`56`	`+ curl_share_close($this->_curlShare);`
	`57`	`+ }`
`55`	`58`	`$this->_curlShare = null;`
`56`	`59`	`}`
`57`	`60`	`}`