GoEnv cannot load .env file

[supengchuan]

use command GoEnv load .env file. But it does not take effect.

I looked at the code and saw that there might be a problem with the line below

go.nvim/lua/go/env.lua

Line 10 in c6d5ca2

if vfn.filereadable(f) then

vfn.filereadable(f) will retrun 0 if f is not readable.

However, in the if conditional statement, if use if 0 then, it will be considered true, which will cause a direct return and result in an inability to load the environment file.

[rodrigc]

@supengchuan You are right. filereadble() return 0 or 1, so we always need
to compare the return value explicitly in conditionals.

Can you verify this fix: #604

[Legion-101]

Hi, is the GoEnv command executed to load the file at startup automatically or does it need to be used manually before running GoDebug?

[rodrigc]

@Legion-101 GoEnv is separate from GoDebug:

go.nvim/doc/go.txt

Line 317 in d89ea7a

Load envfile and set environment variable

[Legion-101]

@rodrigc
I just thought that to load variables from a file specified in the config file for DAP, loading occurs in the same way as in GoEnv

[rodrigc]

@Legion-101 double check

go.nvim/doc/go.txt

Line 280 in d89ea7a

:GoDebug {options} *:GoDebug*

to confirm GoDebug

[Legion-101]

Thank you very much.
Now I don't understand why loading env variables from such a configuration might not work.

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch test",
            "cwd": "${workspaceFolder}",
            "type": "go",
            "request": "launch",
            "mode": "debug",
            "program": "${workspaceFolder}/cmd/test",
            "envFile": "${workspaceFolder}/.env"
        }
    ]
}

In VSCode it works, but in nvim the variables are not loaded.

[rodrigc]

@Legion-101 it looks like GoEnv:

go.nvim/doc/go.txt

Line 316 in d89ea7a

:GoEnv {envfile} {load} *:GoEnv*

go.nvim/lua/go/env.lua

Line 10 in d89ea7a

if vfn.filereadable(f) then

does not use launch.json.

and the code which parses launch.json doesn't look like it parses envFile:

https://github.com/ray-x/go.nvim/blob/d89ea7aba93220383ded5bb22b1e82841980cecf/lua/go/launch.lua

That might be another bug.

[Legion-101]

If I run the command :GoDbgConfig, my launch.json file opens.

Judging by the code, the file does indeed open and load into DAP, but I don't understand whether I need to automate this myself or whether GoDebug will automatically load the .env from the specified path.

go.nvim/lua/go/launch.lua

Lines 91 to 95 in d89ea7a

	local launch_json = _GO_NVIM_CFG.launch_json or (workfolder .. sep .. ".vscode" .. sep .. "launch.json")
	log(launch_json)
	if vfn.filereadable(launch_json) == 1 then
	return true, launch_json
	else

@rodrigc It turns out that in the current version this will not work at all and we should wait for the fixes, since automatic parsing of .env simply does not work when launched manually GoEnv or start debug session

[ray-x]

Thanks @rodrigc for the PR. @Legion-101 Could you check if the latest version works for you?

[Legion-101]

@rodrigc Thank you very much for the PR, it really helped me
@ray-x I checked that the GoEnv command loads environment variables.

But I think constantly calling GoEnv before GoDebug is inconvenient. I'll try setting up autocmd, but maybe it's worth considering calling GoEnv directly from lua?

I also discovered that parsing .env ignores comments in the file and overwrites environment variables.

[rodrigc]

@ray-x if envFile is specified in launch.json like here: https://github.com/ray-x/go.nvim/blob/d89ea7aba93220383ded5bb22b1e82841980cecf/lua/go/launch.lua

should that load in the envFiile via GoEnv? Or is the launch.json envFile completely different from GoEnv?