Skip to content

Commit 033ffcc

Browse files
vincentriemerfacebook-github-bot
authored andcommitted
Remove unecessary PointerEvent attributes
Summary: Changelog: [iOS][Internal] Remove unecessary PointerEvent attributes Reviewed By: kacieb Differential Revision: D37115465 fbshipit-source-id: 079a297d1ce5b3d2c6766036a111c73bd75535f1
1 parent 7b0ba6d commit 033ffcc

4 files changed

Lines changed: 0 additions & 18 deletions

File tree

React/Fabric/RCTSurfaceTouchHandler.mm

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,6 @@ static PointerEvent CreatePointerEventFromActiveTouch(ActiveTouch activeTouch)
180180
event.pressure = touch.force;
181181
event.pointerType = PointerTypeCStringFromUITouchType(activeTouch.touchType);
182182
event.clientPoint = touch.pagePoint;
183-
event.target = touch.target;
184-
event.timestamp = touch.timestamp;
185183
return event;
186184
}
187185

@@ -196,8 +194,6 @@ static PointerEvent CreatePointerEventFromActiveTouch(ActiveTouch activeTouch)
196194
event.pressure = 0.0;
197195
event.pointerType = "mouse";
198196
event.clientPoint = RCTPointFromCGPoint(clientLocation);
199-
event.target = (Tag)view.tag;
200-
event.timestamp = timestamp;
201197
return event;
202198
}
203199

ReactCommon/react/renderer/components/view/PointerEvent.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ std::vector<DebugStringConvertibleObject> getDebugProps(
2424
{"pressure", getDebugDescription(pointerEvent.pressure, options)},
2525
{"pointerType", getDebugDescription(pointerEvent.pointerType, options)},
2626
{"clientPoint", getDebugDescription(pointerEvent.clientPoint, options)},
27-
{"target", getDebugDescription(pointerEvent.target, options)},
28-
{"timestamp", getDebugDescription(pointerEvent.timestamp, options)},
2927
};
3028
}
3129

ReactCommon/react/renderer/components/view/PointerEvent.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,6 @@ struct PointerEvent {
3434
* opposed to the coordinate within the page).
3535
*/
3636
Point clientPoint;
37-
/*
38-
* A reference to the view to which the event was originally dispatched.
39-
*/
40-
Tag target;
41-
/*
42-
* The time at which the event was created (in milliseconds). By
43-
* specification, this value is time since epoch—but in reality, browsers'
44-
* definitions vary.
45-
*/
46-
Float timestamp;
4737
};
4838

4939
#if RN_DEBUG_STRING_CONVERTIBLE

ReactCommon/react/renderer/components/view/TouchEventEmitter.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ static jsi::Value pointerEventPayload(
6868
object.setProperty(runtime, "pointerType", event.pointerType);
6969
object.setProperty(runtime, "clientX", event.clientPoint.x);
7070
object.setProperty(runtime, "clientY", event.clientPoint.y);
71-
object.setProperty(runtime, "target", event.target);
72-
object.setProperty(runtime, "timestamp", event.timestamp * 1000);
7371
return object;
7472
}
7573

0 commit comments

Comments
 (0)