Skip to content

Commit 0c947c8

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Fix diffApiSnapshot-test (#54903)
Summary: Pull Request resolved: #54903 A bit too trigger happy on D89287801(!) Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D89292895 fbshipit-source-id: 793d984253dcf24c394adc8c8646992caf17805d
1 parent 73d3429 commit 0c947c8

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

scripts/js-api/diff-api-snapshot/__tests__/diffApiSnapshot-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe('diffApiSnapshot', () => {
4949
expect(res.changedApis).toEqual(['DeletedExport']);
5050
});
5151

52-
test('should detect breaking change when a statement is changed', () => {
52+
test('should detect potentially breaking change when a statement is changed', () => {
5353
const prevSnapshot = `
5454
import * as React from 'react';
5555
export declare type AccessibilityActionEvent = NativeSyntheticEvent<
@@ -78,11 +78,11 @@ describe('diffApiSnapshot', () => {
7878
`;
7979

8080
const res = diffApiSnapshot(prevSnapshot, newSnapshot);
81-
expect(res.result).toBe(Result.BREAKING);
81+
expect(res.result).toBe(Result.POTENTIALLY_BREAKING);
8282
expect(res.changedApis).toEqual(['Foo']);
8383
});
8484

85-
test('should detect potentially not breaking change when a statement is added', () => {
85+
test('should detect potentially non-breaking change when a statement is added', () => {
8686
const prevSnapshot = `
8787
import * as React from 'react';
8888
declare type AccessibilityActionEvent = NativeSyntheticEvent<
@@ -117,7 +117,7 @@ describe('diffApiSnapshot', () => {
117117
expect(res.changedApis).toEqual(['NewExport']);
118118
});
119119

120-
test('should detect not breaking change when nothing is changed', () => {
120+
test('should detect non-breaking change when nothing is changed', () => {
121121
const prevSnapshot = `
122122
import * as React from 'react';
123123
declare type AccessibilityActionEvent = NativeSyntheticEvent<

0 commit comments

Comments
 (0)