Skip to content

Commit 0fe23d7

Browse files
MegaManSecmeta-codesync[bot]
authored andcommitted
Fix modal hover interception to call the correct super method (#54991)
Summary: Fixes an incorrect super call in `ReactModalHostView.onInterceptHoverEvent`. The method was returning `super.onHoverEvent(event)`, which bypasses the intended interception behavior and can cause inconsistent hover/pointer dispatching for modals. This change ensures the intercept hook delegates to the correct superclass implementation. ## Changelog: [ANDROID] [FIXED] - Fix `ReactModalHostView` hover interception to call `super.onInterceptHoverEvent` instead of `super.onHoverEvent`. Pull Request resolved: #54991 Test Plan: * Built Android locally: * `./gradlew :packages:react-native:ReactAndroid:assembleDebug` Reviewed By: cipolleschi, christophpurrer Differential Revision: D89887915 Pulled By: cortinico fbshipit-source-id: 53d16bdbb1f88097814c2f06fca3601ff3d57cbd
1 parent e6923dd commit 0fe23d7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ public class ReactModalHostView(context: ThemedReactContext) :
593593

594594
override fun onInterceptHoverEvent(event: MotionEvent): Boolean {
595595
eventDispatcher?.let { jSPointerDispatcher?.handleMotionEvent(event, it, true) }
596-
return super.onHoverEvent(event)
596+
return super.onInterceptHoverEvent(event)
597597
}
598598

599599
override fun onHoverEvent(event: MotionEvent): Boolean {

0 commit comments

Comments
 (0)